Add Python 3.12 to the CPU test matrix #20078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20078 +/- ##
=======================================
Coverage 90% 90%
=======================================
Files 266 266
Lines 22961 22961
=======================================
Hits 20690 20690
Misses 2271 2271 |
github-actions
bot
added
fabric
awaelchli
added
the
fun
awaelchli
force-pushed
the
tests/python312
branch
from
66a8c38 to
bf781f7
Compare
awaelchli
force-pushed
the
tests/python312
branch
from
3d20f4d to
f19baea
Compare
for more information, see https://pre-commit.ci
awaelchli
requested review from
Borda,
justusschock,
ethanwharris,
lantiga and
tchaton
as code owners
Borda
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Python 3.12 to the test matrix for PyTorch 3.12.
For consistency, I'm distributing the other Python versions (3.10 and 3.11) to the PyTorch versions 2.1, 2.2, 2.3 so that it's easier to establish a pattern while still remaining diverse enough to cover the common combinations.
This PR only deals with the CPU tests for now. Will do GPU in a separate PR.
Notable updates:
isinstance(LightningOptimizer(), Optimizable)against our runtime-checkable Optimizable class no longer works. But there is no real use case for this, except one test which asserted this, and I removed it because it does not reflect a real use case.cc @carmocca @Borda @justusschock @awaelchli