Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test for legacy checkpoint created with 2.2.2 #19760

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Adding test for legacy checkpoint created with 2.2.2 #19760

merged 1 commit into from
Apr 12, 2024

Conversation

pl-ghost
Copy link
Contributor

@pl-ghost pl-ghost commented Apr 11, 2024 •
edited by github-actions bot
Loading

This is automated addition of created checkpoints with the latest lightning release!

cc @Borda @awaelchli

@pl-ghost pl-ghost requested a review from lantiga as a code owner April 11, 2024 13:32
@pl-ghost pl-ghost added the checkpointing Related to checkpointing label Apr 11, 2024
@pl-ghost pl-ghost requested a review from Borda as a code owner April 11, 2024 13:32
@pl-ghost pl-ghost added the pl Generic label for PyTorch Lightning package label Apr 11, 2024
@pl-ghost pl-ghost requested a review from tchaton as a code owner April 11, 2024 13:32
@pl-ghost pl-ghost added the tests label Apr 11, 2024
@pl-ghost pl-ghost requested a review from awaelchli as a code owner April 11, 2024 13:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.13, oldest) success ✅
pl-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
pl-cpu (macOS-11, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-11, lightning, 3.10, 2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.2) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success ✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0) success ✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0) success ✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success ✅

These checks are required after the changes to tests/legacy/back-compatible-versions.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@pl-ghost pl-ghost requested a review from Borda April 11, 2024 19:09
@mergify mergify bot added the ready PRs ready to be merged label Apr 12, 2024
@awaelchli awaelchli merged commit 67b270b into master Apr 12, 2024
41 checks passed
@awaelchli awaelchli deleted the create-pull-request/patch branch April 12, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees

@Borda Borda

Labels
checkpointing Related to checkpointing pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pl-ghost @awaelchli @Borda