Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping tags in Fabric docs on small screens #19692

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

judidoko
Copy link
Contributor

@judidoko judidoko commented Mar 24, 2024

What does this PR do?

Fix the UI issue on https://lightning.ai/docs/fabric/stable/examples/. Tags are overlapping on text.

Fixes #19669

before submit - Was this **discussed/agreed** via a GitHub issue? yes - [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/lightning/blob/master/.github/CONTRIBUTING.md), **Pull Request** section? Yes I did - [ ] Did you make sure your **PR does only one thing**, instead of bundling different changes together? Yes I did - Did you make sure to **update the documentation** with your changes? (if necessary) - Did you write any **new necessary tests**? (not for typos and docs) - [ ] Did you verify new and **existing tests pass** locally with your changes? Yes I did - Did you list all the **breaking changes** introduced by this pull request? - Did you **update the CHANGELOG**? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19692.org.readthedocs.build/en/19692/

@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric labels Mar 24, 2024
@judidoko judidoko changed the title UI Issue: Fix overlapping tags UI Issue: Fix over-lagging tags Mar 24, 2024
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls add screeshot from the original and update version?

@judidoko
Copy link
Contributor Author

Original Version.

before fixing

Updated Version
Fix page

@awaelchli awaelchli changed the title UI Issue: Fix over-lagging tags Fix overlapping tags in Fabric docs on small screens Mar 27, 2024
@awaelchli awaelchli added the community This PR is from the community label Mar 27, 2024
@awaelchli awaelchli added this to the 2.3 milestone Mar 27, 2024
@awaelchli awaelchli merged commit b0782ad into Lightning-AI:master Mar 27, 2024
23 checks passed
@mergify mergify bot added the ready PRs ready to be merged label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community docs Documentation related fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI issue with Documentation
3 participants