Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

state maintenance in DataParallel #1895

Closed
wants to merge 24 commits into from
Closed

state maintenance in DataParallel #1895

wants to merge 24 commits into from

Conversation

ananyahjha93
Copy link
Contributor

@ananyahjha93 ananyahjha93 commented May 19, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

WIP. This fails on a few cases of variable declaration.
Tries to fix #565.
#1649 is slightly different from simple state maintenance in DataParallel.

PR review

Need to be reviewed by core maintainers as it changes the way DataParallel works in default PyTorch.

Did you have fun?

Yes! :)

@pep8speaks
Copy link

pep8speaks commented May 19, 2020 •
edited
Loading

Hello @ananyahjha93! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-05 20:26:09 UTC

@mergify mergify bot requested a review from a team May 19, 2020 17:46
@Borda Borda added the feature Is an improvement or enhancement label May 19, 2020
@nsarang nsarang mentioned this pull request May 22, 2020
Closed
@ananyahjha93 ananyahjha93 mentioned this pull request May 31, 2020
Merged
1 task
@codecov
Copy link

codecov bot commented Jun 1, 2020 •
edited
Loading

Codecov Report

Merging #1895 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1895   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files          70      70           
  Lines        5689    5732   +43     
======================================
+ Hits         5185    5228   +43     
  Misses        504     504

@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2020

This pull request is now in conflict... :(

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2020

This pull request is now in conflict... :(

@ananyahjha93 ananyahjha93 changed the title [wip] non-working commit for state maintenance in DataParallel state maintenance in DataParallel Jun 8, 2020
@ananyahjha93
Copy link
Contributor Author

@Borda hey, this is done from my side but there is merge conflict because I added another parent class to LightningModule.

Borda
Borda reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition 🦝

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pl_examples/basic_examples/state_maintenance_dp_demo.py Outdated Show resolved Hide resolved
@Borda Borda added the example label Jun 8, 2020
@Borda Borda added this to the 0.8.0 milestone Jun 8, 2020
@mergify mergify bot requested a review from a team June 8, 2020 13:17
@stale
Copy link

stale bot commented Oct 27, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Oct 27, 2020
@SkafteNicki SkafteNicki mentioned this pull request Oct 28, 2020
Closed
@stale
Copy link

stale bot commented Nov 1, 2020

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Nov 1, 2020
@ananyahjha93 ananyahjha93 removed the won't fix This will not be worked on label Nov 2, 2020
@SkafteNicki SkafteNicki mentioned this pull request Nov 3, 2020
Merged
8 tasks
@marrrcin
Copy link

marrrcin commented Nov 3, 2020 •
edited
Loading

Is this going to be re-opened? Following it from #4353 (comment)

@ananyahjha93
Copy link
Contributor Author

@marrrcin Yes, I think this is required to solve the DP metric bug in #4353.

@edenlightning edenlightning reopened this Nov 5, 2020
@Borda
Copy link
Member

Borda commented Nov 30, 2020

@ananyahjha93 can we get this done by end of this week to pass it in 1.1? 🐰

@edenlightning edenlightning modified the milestones: 1.1, 1.2 Dec 8, 2020
@Borda Borda changed the base branch from master to release/1.2-dev December 14, 2020 17:36
@Borda Borda dismissed justusschock’s stale review December 14, 2020 17:36

The base branch was changed.

@jdb78 jdb78 mentioned this pull request Dec 29, 2020
Open
@Borda
Copy link
Member

Borda commented Jan 26, 2021

@ananyahjha93 how is going here? cc: @tchaton

@edenlightning edenlightning modified the milestones: 1.2, 1.3 Feb 8, 2021
Base automatically changed from release/1.2-dev to master February 11, 2021 14:31
@lexierule lexierule requested a review from carmocca as a code owner February 11, 2021 14:31
@tchaton
Copy link
Contributor

tchaton commented Feb 15, 2021

Hey @ananthsub,

Any updates on this one ?

Best,
T.C

@ananyahjha93
Copy link
Contributor Author

ananyahjha93 commented Feb 16, 2021 •
edited
Loading

@tchaton needs to be redone after accelerator refactor. Too many changes in the codebase since this was done.

@tchaton tchaton closed this Feb 26, 2021
@vlievin
Copy link

vlievin commented Dec 19, 2021

Hi @ananyahjha93, any update on that one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@justusschock justusschock justusschock left review comments

@awaelchli awaelchli Awaiting requested review from awaelchli

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@tullie tullie Awaiting requested review from tullie

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@carmocca carmocca Awaiting requested review from carmocca

Assignees

@tchaton tchaton

Labels
example feature Is an improvement or enhancement has conflicts
Projects
None yet
Milestone
pl:1.3
Development

Successfully merging this pull request may close these issues.

State maintenance in DP