ci: testing with py3.11 #17822

Borda · 2023-06-13T15:00:51Z

What does this PR do?

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @awaelchli

github-actions · 2023-06-13T15:01:29Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, src/lightning_fabric/__setup__.py, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/pytorch/loops/evaluation_loop.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/pytorch_lightning/__setup__.py, tests/tests_pytorch/trainer/connectors/test_checkpoint_connector.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py, tests/tests_pytorch/utilities/test_exceptions.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
[pytorch-lightning (GPUs) (testing Lightning	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=171682&view=logs&jobId=47e66f3c-897a-5428-da11-bf5c7745762e)	success
[pytorch-lightning (GPUs) (testing PyTorch	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=171682&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f)	success

These checks are required after the changes to requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/__setup__.py, src/lightning/pytorch/loops/evaluation_loop.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/pytorch_lightning/__setup__.py, tests/tests_pytorch/trainer/connectors/test_checkpoint_connector.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py, tests/tests_pytorch/utilities/test_exceptions.py, tests/tests_pytorch/utilities/test_imports.py, src/lightning_fabric/__setup__.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/pytorch/loops/evaluation_loop.py, src/lightning/pytorch/trainer/connectors/data_connector.py.

🟢 fabric: Docs

Check ID	Status
docs-checks (fabric, doctest)	success	✅
make-html (fabric)	success	✅

These checks are required after the changes to src/lightning_fabric/__setup__.py.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-checks (pytorch, doctest)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/lightning/pytorch/loops/evaluation_loop.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/pytorch_lightning/__setup__.py, requirements/pytorch/examples.txt, requirements/pytorch/test.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.12, 11.7.1)	success	✅
build-cuda (3.9, 1.13, 11.8.0)	success	✅
build-cuda (3.9, 1.13, 12.0.1)	success	✅
build-cuda (3.10, 2.0, 11.8.0)	success	✅
build-cuda (3.10, 2.0, 12.0.1)	success	✅
build-pl (3.9, 1.12, 11.7.1)	success	✅
build-pl (3.9, 1.13, 11.8.0)	success	✅
build-pl (3.9, 1.13, 12.0.1)	success	✅
build-pl (3.10, 2.0, 11.8.0)	success	✅
build-pl (3.10, 2.0, 12.0.1)	success	✅

These checks are required after the changes to requirements/pytorch/examples.txt, requirements/pytorch/test.txt.

🟢 lightning_data: CPU workflow

Check ID	Status
data-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
data-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
data-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-data.yml.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0)	success	✅

These checks are required after the changes to src/lightning_fabric/__setup__.py, tests/tests_fabric/utilities/test_imports.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
[lightning-fabric (GPUs) (testing Fabric	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=171686&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f)	success
[lightning-fabric (GPUs) (testing Lightning	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=171686&view=logs&jobId=47e66f3c-897a-5428-da11-bf5c7745762e)	success

These checks are required after the changes to src/lightning/__setup__.py, src/lightning_fabric/__setup__.py, tests/tests_fabric/utilities/test_imports.py.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (macOS-12, app, 3.11, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (ubuntu-22.04, app, 3.11, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.11, latest)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-app.yml, src/lightning_app/__setup__.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning_app/__setup__.py.

🟢 lightning: Store

Check ID	Status
store-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
store-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
store-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅

These checks are required after the changes to src/lightning/__setup__.py.

🟢 lightning_app: Docs

Check ID	Status
docs-checks (app, doctest)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning_app/__setup__.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/__setup__.py, src/lightning/pytorch/loops/evaluation_loop.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/lightning_app/__setup__.py, src/lightning_fabric/__setup__.py, src/pytorch_lightning/__setup__.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.11)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to .github/workflows/ci-pkg-install.yml, src/lightning/__setup__.py, src/lightning/pytorch/loops/evaluation_loop.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/lightning_app/__setup__.py, src/lightning_fabric/__setup__.py, src/pytorch_lightning/__setup__.py, requirements/pytorch/examples.txt, requirements/pytorch/test.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Borda · 2023-06-13T15:15:22Z

some dependencies could be updated much sooner like onnixruntime, encreasing queue in #17823

codecov · 2023-06-15T12:45:47Z

Codecov Report

Merging #17822 (bc9cbd5) into master (ed06956) will decrease coverage by 3%.
The diff coverage is 100%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #17822    +/-   ##
========================================
- Coverage      85%      82%    -3%     
========================================
  Files         427      427            
  Lines       33216    33216            
========================================
- Hits        28111    27268   -843     
- Misses       5105     5948   +843

…ch-lightning into ci/py3.11

src/lightning/pytorch/trainer/connectors/data_connector.py

tests/tests_pytorch/utilities/test_exceptions.py

.github/workflows/ci-tests-fabric.yml

.github/workflows/ci-tests-pytorch.yml

ci: testing with py3.11

bff2b0c

Borda requested review from carmocca and ethanwharris as code owners June 13, 2023 15:00

Borda enabled auto-merge (squash) June 13, 2023 15:01

github-actions bot added ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jun 13, 2023

Borda requested a review from a team June 13, 2023 15:01

onnxruntime

792ee44

Borda requested review from lantiga, tchaton and awaelchli as code owners June 13, 2023 15:10

Borda force-pushed the ci/py3.11 branch from f6f6197 to 792ee44 Compare June 13, 2023 15:19

Borda and others added 3 commits June 13, 2023 17:23

protobuf

82b77df

protobuf-compiler

5b723ec

Merge branch 'master' into ci/py3.11

1912fc1

awaelchli approved these changes Jun 16, 2023

View reviewed changes

carmocca and others added 4 commits June 16, 2023 04:17

Merge branch 'master' into ci/py3.11

605cc5c

Merge branch 'master' into ci/py3.11

74f1d61

Merge branch 'master' into ci/py3.11

3ae60ae

Merge branch 'master' into ci/py3.11

32afede

Borda requested a review from justusschock as a code owner August 8, 2023 15:37

Borda and others added 5 commits August 10, 2023 09:40

Merge branch 'master' into ci/py3.11

15e19b3

Merge branch 'master' into ci/py3.11

a19f0a2

Merge branch 'master' into ci/py3.11

63bedc9

switch to sub pkg

d569b9f

just addition

9445815

Borda added 2 commits August 23, 2023 17:11

drop protobuf

1497fa1

install 3.11

f018a31

mergify bot added the has conflicts label Aug 23, 2023

Merge branch 'master' into ci/py3.11

cf7bc77

mergify bot removed the has conflicts label Aug 23, 2023

Borda added 2 commits August 23, 2023 17:53

tags

48c2545

Merge branch 'ci/py3.11' of https://github.com/PyTorchLightning/pytor…

5b17719

…ch-lightning into ci/py3.11

github-actions bot added the app (removed) Generic label for Lightning App package label Aug 23, 2023

Borda requested a review from awaelchli August 23, 2023 15:54

awaelchli added 2 commits August 25, 2023 03:36

Merge branch 'master' into ci/py3.11

edd113d

enum fixes

375f130

awaelchli requested a review from williamFalcon as a code owner August 25, 2023 02:00

awaelchli mentioned this pull request Aug 25, 2023

Improve error message for ddp unused parameters on Python 3.11 #18399

Merged

awaelchli added 2 commits August 25, 2023 23:13

debug

dcb06d9

Merge branch 'master' into ci/py3.11

236f2f4

awaelchli added this to the 2.1 milestone Aug 25, 2023

debug

b874f8c

awaelchli reviewed Aug 25, 2023

View reviewed changes

src/lightning/pytorch/trainer/connectors/data_connector.py Show resolved Hide resolved

fix augment message

176f322

awaelchli reviewed Aug 25, 2023

View reviewed changes

tests/tests_pytorch/utilities/test_exceptions.py Show resolved Hide resolved

Borda changed the title ~~ci: testing with py3.11 [wip]~~ ci: testing with py3.11 Aug 25, 2023

awaelchli approved these changes Aug 25, 2023

View reviewed changes

carmocca reviewed Aug 28, 2023

View reviewed changes

.github/workflows/ci-tests-fabric.yml Show resolved Hide resolved

.github/workflows/ci-tests-pytorch.yml Show resolved Hide resolved

Borda and others added 2 commits August 28, 2023 16:30

gc

8d7ac8e

Merge branch 'master' into ci/py3.11

bc9cbd5

Borda requested a review from carmocca August 28, 2023 14:30

justusschock approved these changes Aug 28, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Aug 28, 2023

Borda merged commit 7509601 into master Aug 28, 2023

Borda deleted the ci/py3.11 branch August 28, 2023 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: testing with py3.11 #17822

ci: testing with py3.11 #17822

Borda commented Jun 13, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jun 13, 2023 •

edited

Loading

Borda commented Jun 13, 2023

codecov bot commented Jun 15, 2023 •

edited

Loading

ci: testing with py3.11 #17822

ci: testing with py3.11 #17822

Conversation

Borda commented Jun 13, 2023 • edited by github-actions bot Loading

What does this PR do?

PR review

github-actions bot commented Jun 13, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

Borda commented Jun 13, 2023

codecov bot commented Jun 15, 2023 • edited Loading

Codecov Report

Borda commented Jun 13, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jun 13, 2023 •

edited

Loading

codecov bot commented Jun 15, 2023 •

edited

Loading