ruff: enable & fixing RET #17540

Borda · 2023-05-01T20:43:37Z

What does this PR do?

improve the codebase health and readability by applying RET check

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @awaelchli

Borda · 2023-05-01T20:44:07Z

a few last are pending on resolution from astral-sh/ruff#4173

github-actions · 2023-05-01T20:44:15Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/fabric/accelerators/cpu.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py, src/lightning/fabric/loggers/csv_logs.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/launchers/subprocess_script.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/utilities/data.py, src/lightning/fabric/utilities/device_parser.py, src/lightning/fabric/utilities/logger.py, src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/accelerators/cpu.py, src/lightning/pytorch/accelerators/cuda.py, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/callbacks/lr_monitor.py, src/lightning/pytorch/callbacks/model_summary.py, src/lightning/pytorch/callbacks/progress/tqdm_progress.py, src/lightning/pytorch/callbacks/timer.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/demos/mnist_datamodule.py, src/lightning/pytorch/loggers/csv_logs.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/utilities.py, src/lightning/pytorch/loops/optimization/automatic.py, src/lightning/pytorch/loops/prediction_loop.py, src/lightning/pytorch/profilers/profiler.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/call.py, src/lightning/pytorch/trainer/configuration_validator.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/data.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/parsing.py, tests/tests_pytorch/callbacks/test_finetuning_callback.py, tests/tests_pytorch/callbacks/test_lr_monitor.py, tests/tests_pytorch/core/test_datamodules.py, tests/tests_pytorch/helpers/advanced_models.py, tests/tests_pytorch/helpers/simple_models.py, tests/tests_pytorch/helpers/utils.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_neptune.py, tests/tests_pytorch/loops/test_fetchers.py, tests/tests_pytorch/loops/test_flow_warnings.py, tests/tests_pytorch/loops/test_loops.py, tests/tests_pytorch/loops/test_training_loop.py, tests/tests_pytorch/loops/test_training_loop_flow_dict.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/trainer/optimization/test_optimizers.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/utilities/test_all_gather_grad.py, pyproject.toml.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to .actions/assistant.py, examples/pytorch/basics/backbone_image_classifier.py, examples/pytorch/basics/autoencoder.py, src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/accelerators/cpu.py, src/lightning/pytorch/accelerators/cuda.py, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/callbacks/lr_monitor.py, src/lightning/pytorch/callbacks/model_summary.py, src/lightning/pytorch/callbacks/progress/tqdm_progress.py, src/lightning/pytorch/callbacks/timer.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/demos/mnist_datamodule.py, src/lightning/pytorch/loggers/csv_logs.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/utilities.py, src/lightning/pytorch/loops/optimization/automatic.py, src/lightning/pytorch/loops/prediction_loop.py, src/lightning/pytorch/profilers/profiler.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/call.py, src/lightning/pytorch/trainer/configuration_validator.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/data.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/parsing.py, tests/tests_pytorch/callbacks/test_finetuning_callback.py, tests/tests_pytorch/callbacks/test_lr_monitor.py, tests/tests_pytorch/core/test_datamodules.py, tests/tests_pytorch/helpers/advanced_models.py, tests/tests_pytorch/helpers/simple_models.py, tests/tests_pytorch/helpers/utils.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_neptune.py, tests/tests_pytorch/loops/test_fetchers.py, tests/tests_pytorch/loops/test_flow_warnings.py, tests/tests_pytorch/loops/test_loops.py, tests/tests_pytorch/loops/test_training_loop.py, tests/tests_pytorch/loops/test_training_loop_flow_dict.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/trainer/optimization/test_optimizers.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/utilities/test_all_gather_grad.py, pyproject.toml, src/lightning/fabric/accelerators/cpu.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py, src/lightning/fabric/loggers/csv_logs.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/launchers/subprocess_script.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/utilities/data.py, src/lightning/fabric/utilities/device_parser.py, src/lightning/fabric/utilities/logger.py.

🟢 fabric: Docs

Check ID	Status
make-doctest (fabric)	success	✅
make-html (fabric)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cpu.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py, src/lightning/fabric/loggers/csv_logs.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/launchers/subprocess_script.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/utilities/data.py, src/lightning/fabric/utilities/device_parser.py, src/lightning/fabric/utilities/logger.py, pyproject.toml.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/accelerators/cpu.py, src/lightning/pytorch/accelerators/cuda.py, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/callbacks/lr_monitor.py, src/lightning/pytorch/callbacks/model_summary.py, src/lightning/pytorch/callbacks/progress/tqdm_progress.py, src/lightning/pytorch/callbacks/timer.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/demos/mnist_datamodule.py, src/lightning/pytorch/loggers/csv_logs.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/utilities.py, src/lightning/pytorch/loops/optimization/automatic.py, src/lightning/pytorch/loops/prediction_loop.py, src/lightning/pytorch/profilers/profiler.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/call.py, src/lightning/pytorch/trainer/configuration_validator.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/data.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/parsing.py, .actions/assistant.py, pyproject.toml.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.11, 11.3.1)	success	✅
build-cuda (3.9, 1.12, 11.6.1)	success	✅
build-cuda (3.9, 1.13, 11.7.1)	success	✅
build-cuda (3.10, 2.0, 11.7.1)	success	✅
build-NGC	success	✅
build-pl (3.9, 1.11, 11.3.1)	success	✅
build-pl (3.9, 1.12, 11.6.1)	success	✅
build-pl (3.9, 1.13, 11.7.1)	success	✅
build-pl (3.10, 2.0, 11.7.1)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/fabric/accelerators/cpu.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py, src/lightning/fabric/loggers/csv_logs.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/launchers/subprocess_script.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/utilities/data.py, src/lightning/fabric/utilities/device_parser.py, src/lightning/fabric/utilities/logger.py, tests/tests_fabric/helpers/models.py, tests/tests_fabric/parity/models.py, tests/tests_fabric/parity/utils.py, tests/tests_fabric/plugins/precision/test_amp_integration.py, tests/tests_fabric/plugins/precision/test_double_integration.py, tests/tests_fabric/strategies/test_deepspeed_integration.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/utilities/test_apply_func.py, pyproject.toml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to .actions/assistant.py, examples/fabric/build_your_own_trainer/trainer.py, examples/fabric/image_classifier/train_fabric.py, examples/fabric/image_classifier/train_torch.py, examples/fabric/kfold_cv/train_fabric.py, examples/fabric/reinforcement_learning/rl/loss.py, examples/fabric/reinforcement_learning/rl/utils.py, src/lightning/fabric/accelerators/cpu.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py, src/lightning/fabric/loggers/csv_logs.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/launchers/subprocess_script.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/utilities/data.py, src/lightning/fabric/utilities/device_parser.py, src/lightning/fabric/utilities/logger.py, tests/tests_fabric/helpers/models.py, tests/tests_fabric/parity/models.py, tests/tests_fabric/parity/utils.py, tests/tests_fabric/plugins/precision/test_amp_integration.py, tests/tests_fabric/plugins/precision/test_double_integration.py, tests/tests_fabric/strategies/test_deepspeed_integration.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/utilities/test_apply_func.py, pyproject.toml.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/app/cli/cmd_install.py, src/lightning/app/cli/cmd_pl_init.py, src/lightning/app/cli/cmd_react_ui_init.py, src/lightning/app/cli/commands/cd.py, src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/connect/app.py, src/lightning/app/cli/connect/data.py, src/lightning/app/cli/pl-app-template/app.py, src/lightning/app/cli/pl-app-template/core/callbacks.py, src/lightning/app/components/database/utilities.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py, src/lightning/app/components/serve/streamlit.py, src/lightning/app/components/training.py, src/lightning/app/core/api.py, src/lightning/app/core/app.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/utils.py, src/lightning/app/runners/backends/__init__.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/runtime_type.py, src/lightning/app/storage/copier.py, src/lightning/app/storage/drive.py, src/lightning/app/storage/payload.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_helpers.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/data_structures.py, src/lightning/app/utilities/git.py, src/lightning/app/utilities/layout.py, src/lightning/app/utilities/log.py, src/lightning/app/utilities/login.py, src/lightning/app/utilities/openapi.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/packaging/cloud_compute.py, src/lightning/app/utilities/packaging/docker.py, src/lightning/app/utilities/packaging/lightning_utils.py, src/lightning/app/utilities/packaging/tarfile.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/state.py, tests/tests_app/cli/test_ls.py, tests/tests_app/cli/test_rm.py, tests/tests_app/components/database/test_client_server.py, tests/tests_app/core/test_lightning_app.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/app/cli/cmd_install.py, src/lightning/app/cli/cmd_pl_init.py, src/lightning/app/cli/cmd_react_ui_init.py, src/lightning/app/cli/commands/cd.py, src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/connect/app.py, src/lightning/app/cli/connect/data.py, src/lightning/app/cli/pl-app-template/app.py, src/lightning/app/cli/pl-app-template/core/callbacks.py, src/lightning/app/components/database/utilities.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py, src/lightning/app/components/serve/streamlit.py, src/lightning/app/components/training.py, src/lightning/app/core/api.py, src/lightning/app/core/app.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/utils.py, src/lightning/app/runners/backends/__init__.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/runtime_type.py, src/lightning/app/storage/copier.py, src/lightning/app/storage/drive.py, src/lightning/app/storage/payload.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_helpers.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/data_structures.py, src/lightning/app/utilities/git.py, src/lightning/app/utilities/layout.py, src/lightning/app/utilities/log.py, src/lightning/app/utilities/login.py, src/lightning/app/utilities/openapi.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/packaging/cloud_compute.py, src/lightning/app/utilities/packaging/docker.py, src/lightning/app/utilities/packaging/lightning_utils.py, src/lightning/app/utilities/packaging/tarfile.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/state.py, tests/integrations_app/public/test_boring_app.py, tests/integrations_app/public/test_quick_start.py, tests/integrations_app/public/test_template_react_ui.py, tests/integrations_app/public/test_template_streamlit_ui.py, examples/app/pickle_or_not/app.py.

🟢 lightning: Store

Check ID	Status
Store.cloud (test_store Linux)	success	✅
Store.cloud (test_store Mac)	success	✅
Store.cloud (test_store Windows)	success	✅

These checks are required after the changes to src/lightning/store/cloud_api.py, src/lightning/store/save.py, src/lightning/store/utils.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/app/cli/cmd_install.py, src/lightning/app/cli/cmd_pl_init.py, src/lightning/app/cli/cmd_react_ui_init.py, src/lightning/app/cli/commands/cd.py, src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/connect/app.py, src/lightning/app/cli/connect/data.py, src/lightning/app/cli/pl-app-template/app.py, src/lightning/app/cli/pl-app-template/core/callbacks.py, src/lightning/app/components/database/utilities.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py, src/lightning/app/components/serve/streamlit.py, src/lightning/app/components/training.py, src/lightning/app/core/api.py, src/lightning/app/core/app.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/utils.py, src/lightning/app/runners/backends/__init__.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/runtime_type.py, src/lightning/app/storage/copier.py, src/lightning/app/storage/drive.py, src/lightning/app/storage/payload.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_helpers.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/data_structures.py, src/lightning/app/utilities/git.py, src/lightning/app/utilities/layout.py, src/lightning/app/utilities/log.py, src/lightning/app/utilities/login.py, src/lightning/app/utilities/openapi.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/packaging/cloud_compute.py, src/lightning/app/utilities/packaging/docker.py, src/lightning/app/utilities/packaging/lightning_utils.py, src/lightning/app/utilities/packaging/tarfile.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/state.py, examples/app/pickle_or_not/app.py, tests/integrations_app/public/test_boring_app.py, tests/integrations_app/public/test_quick_start.py, tests/integrations_app/public/test_template_react_ui.py, tests/integrations_app/public/test_template_streamlit_ui.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/app/cli/cmd_install.py, src/lightning/app/cli/cmd_pl_init.py, src/lightning/app/cli/cmd_react_ui_init.py, src/lightning/app/cli/commands/cd.py, src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/connect/app.py, src/lightning/app/cli/connect/data.py, src/lightning/app/cli/pl-app-template/app.py, src/lightning/app/cli/pl-app-template/core/callbacks.py, src/lightning/app/components/database/utilities.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py, src/lightning/app/components/serve/streamlit.py, src/lightning/app/components/training.py, src/lightning/app/core/api.py, src/lightning/app/core/app.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/utils.py, src/lightning/app/runners/backends/__init__.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/runtime_type.py, src/lightning/app/storage/copier.py, src/lightning/app/storage/drive.py, src/lightning/app/storage/payload.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_helpers.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/data_structures.py, src/lightning/app/utilities/git.py, src/lightning/app/utilities/layout.py, src/lightning/app/utilities/log.py, src/lightning/app/utilities/login.py, src/lightning/app/utilities/openapi.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/packaging/cloud_compute.py, src/lightning/app/utilities/packaging/docker.py, src/lightning/app/utilities/packaging/lightning_utils.py, src/lightning/app/utilities/packaging/tarfile.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/state.py, pyproject.toml.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/app/cli/cmd_install.py, src/lightning/app/cli/cmd_pl_init.py, src/lightning/app/cli/cmd_react_ui_init.py, src/lightning/app/cli/commands/cd.py, src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/connect/app.py, src/lightning/app/cli/connect/data.py, src/lightning/app/cli/pl-app-template/app.py, src/lightning/app/cli/pl-app-template/core/callbacks.py, src/lightning/app/components/database/utilities.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py, src/lightning/app/components/serve/streamlit.py, src/lightning/app/components/training.py, src/lightning/app/core/api.py, src/lightning/app/core/app.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/utils.py, src/lightning/app/runners/backends/__init__.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/runtime_type.py, src/lightning/app/storage/copier.py, src/lightning/app/storage/drive.py, src/lightning/app/storage/payload.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_helpers.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/data_structures.py, src/lightning/app/utilities/git.py, src/lightning/app/utilities/layout.py, src/lightning/app/utilities/log.py, src/lightning/app/utilities/login.py, src/lightning/app/utilities/openapi.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/packaging/cloud_compute.py, src/lightning/app/utilities/packaging/docker.py, src/lightning/app/utilities/packaging/lightning_utils.py, src/lightning/app/utilities/packaging/tarfile.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/state.py, src/lightning/fabric/accelerators/cpu.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py, src/lightning/fabric/loggers/csv_logs.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/launchers/subprocess_script.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/utilities/data.py, src/lightning/fabric/utilities/device_parser.py, src/lightning/fabric/utilities/logger.py, src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/accelerators/cpu.py, src/lightning/pytorch/accelerators/cuda.py, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/callbacks/lr_monitor.py, src/lightning/pytorch/callbacks/model_summary.py, src/lightning/pytorch/callbacks/progress/tqdm_progress.py, src/lightning/pytorch/callbacks/timer.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/demos/mnist_datamodule.py, src/lightning/pytorch/loggers/csv_logs.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/utilities.py, src/lightning/pytorch/loops/optimization/automatic.py, src/lightning/pytorch/loops/prediction_loop.py, src/lightning/pytorch/profilers/profiler.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/call.py, src/lightning/pytorch/trainer/configuration_validator.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/data.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/parsing.py, src/lightning/store/cloud_api.py, src/lightning/store/save.py, src/lightning/store/utils.py, pyproject.toml.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/app/cli/cmd_install.py, src/lightning/app/cli/cmd_pl_init.py, src/lightning/app/cli/cmd_react_ui_init.py, src/lightning/app/cli/commands/cd.py, src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/connect/app.py, src/lightning/app/cli/connect/data.py, src/lightning/app/cli/pl-app-template/app.py, src/lightning/app/cli/pl-app-template/core/callbacks.py, src/lightning/app/components/database/utilities.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py, src/lightning/app/components/serve/streamlit.py, src/lightning/app/components/training.py, src/lightning/app/core/api.py, src/lightning/app/core/app.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/utils.py, src/lightning/app/runners/backends/__init__.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/runtime_type.py, src/lightning/app/storage/copier.py, src/lightning/app/storage/drive.py, src/lightning/app/storage/payload.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_helpers.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/data_structures.py, src/lightning/app/utilities/git.py, src/lightning/app/utilities/layout.py, src/lightning/app/utilities/log.py, src/lightning/app/utilities/login.py, src/lightning/app/utilities/openapi.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/packaging/cloud_compute.py, src/lightning/app/utilities/packaging/docker.py, src/lightning/app/utilities/packaging/lightning_utils.py, src/lightning/app/utilities/packaging/tarfile.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/state.py, src/lightning/fabric/accelerators/cpu.py, src/lightning/fabric/accelerators/mps.py, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py, src/lightning/fabric/loggers/csv_logs.py, src/lightning/fabric/strategies/ddp.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/strategies/launchers/subprocess_script.py, src/lightning/fabric/strategies/strategy.py, src/lightning/fabric/utilities/data.py, src/lightning/fabric/utilities/device_parser.py, src/lightning/fabric/utilities/logger.py, src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/accelerators/cpu.py, src/lightning/pytorch/accelerators/cuda.py, src/lightning/pytorch/accelerators/mps.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/callbacks/lr_monitor.py, src/lightning/pytorch/callbacks/model_summary.py, src/lightning/pytorch/callbacks/progress/tqdm_progress.py, src/lightning/pytorch/callbacks/timer.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/core/saving.py, src/lightning/pytorch/demos/boring_classes.py, src/lightning/pytorch/demos/mnist_datamodule.py, src/lightning/pytorch/loggers/csv_logs.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/utilities.py, src/lightning/pytorch/loops/optimization/automatic.py, src/lightning/pytorch/loops/prediction_loop.py, src/lightning/pytorch/profilers/profiler.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/call.py, src/lightning/pytorch/trainer/configuration_validator.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/connectors/data_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/data.py, src/lightning/pytorch/utilities/model_summary/model_summary.py, src/lightning/pytorch/utilities/parsing.py, src/lightning/store/cloud_api.py, src/lightning/store/save.py, src/lightning/store/utils.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

codecov · 2023-05-02T14:56:31Z

Codecov Report

Merging #17540 (bd17627) into master (bdf00f9) will decrease coverage by 1%.
The diff coverage is 68%.

❗ Current head bd17627 differs from pull request most recent head dd64537. Consider uploading reports for the commit dd64537 to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #17540    +/-   ##
========================================
- Coverage      85%      84%    -1%     
========================================
  Files         419      419            
  Lines       31647    31613    -34     
========================================
- Hits        26810    26435   -375     
- Misses       4837     5178   +341

Borda · 2023-05-05T07:23:17Z

another case in astral-sh/ruff#4236

(cherry picked from commit 4413e98)

ruff: enable & fixing RET

df667c8

Borda requested review from tchaton, lantiga, awaelchli, ethanwharris, carmocca, justusschock and williamFalcon as code owners May 1, 2023 20:43

github-actions bot added app (removed) Generic label for Lightning App package ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels May 1, 2023

Merge branch 'master' into ruff/RET

bd17627

carmocca approved these changes May 3, 2023

View reviewed changes

mergify bot added the has conflicts label May 4, 2023

Merge branch 'master' into ruff/RET

dd64537

mergify bot removed the has conflicts label May 4, 2023

Merge branch 'master' into ruff/RET

b170d73

mergify bot added the has conflicts label May 5, 2023

lantiga approved these changes May 5, 2023

View reviewed changes

Merge branch 'master' into ruff/RET

cdf10e8

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 5, 2023

todo

f56a106

Borda enabled auto-merge (squash) May 5, 2023 07:30

Borda and others added 3 commits May 5, 2023 10:13

rev

8f2ef01

Merge branch 'master' into ruff/RET

64b777f

todo

ed63b42

Borda merged commit 4413e98 into master May 5, 2023

Borda deleted the ruff/RET branch May 5, 2023 09:34

Borda added a commit that referenced this pull request Jun 1, 2023

ruff: enable & fixing RET (#17540)

3c0008e

(cherry picked from commit 4413e98)

Borda added a commit that referenced this pull request Jun 1, 2023

ruff: enable & fixing RET (#17540)

f57aa03

(cherry picked from commit 4413e98)

lantiga pushed a commit that referenced this pull request Jun 2, 2023

ruff: enable & fixing RET (#17540)

69fcabb

(cherry picked from commit 4413e98)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ruff: enable & fixing RET #17540

ruff: enable & fixing RET #17540

Borda commented May 1, 2023 •

edited by github-actions bot

Loading

Borda commented May 1, 2023

github-actions bot commented May 1, 2023 •

edited

Loading

codecov bot commented May 2, 2023 •

edited

Loading

Borda commented May 5, 2023

ruff: enable & fixing RET #17540

ruff: enable & fixing RET #17540

Conversation

Borda commented May 1, 2023 • edited by github-actions bot Loading

What does this PR do?

PR review

Borda commented May 1, 2023

github-actions bot commented May 1, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

codecov bot commented May 2, 2023 • edited Loading

Codecov Report

Borda commented May 5, 2023

Borda commented May 1, 2023 •

edited by github-actions bot

Loading

github-actions bot commented May 1, 2023 •

edited

Loading

codecov bot commented May 2, 2023 •

edited

Loading