Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Lightning App with remote storage #17426

Merged
merged 30 commits into from
Apr 23, 2023
Merged

Resolve Lightning App with remote storage #17426

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
50b9172
update
Apr 21, 2023
ef77a84
update
Apr 21, 2023
1220b33
update
Apr 21, 2023
1ce64b7
update
Apr 21, 2023
525c1d1
update
Apr 21, 2023
4680b40
update
Apr 21, 2023
76050cb
update
Apr 21, 2023
a3cbdf3
update
Apr 21, 2023
ccf036d
update
Apr 21, 2023
ce0d73d
update
Apr 21, 2023
7867342
update
Apr 21, 2023
e9acf43
update
Apr 21, 2023
0d37de8
update
Apr 21, 2023
f13db97
Merge branch 'master' into debug_drive
tchaton Apr 22, 2023
2d18bdf
update
Apr 23, 2023
9883588
Merge branch 'debug_drive' of https://github.com/Lightning-AI/lightni…
Apr 23, 2023
0efd806
update
Apr 23, 2023
f58fd07
update
Apr 23, 2023
d5fdc2f
update
Apr 23, 2023
44d8641
update
Apr 23, 2023
88875a1
update
Apr 23, 2023
a64743e
update
Apr 23, 2023
423f9e9
update
Apr 23, 2023
dbecd0d
update
Apr 23, 2023
dbb3bd1
update
Apr 23, 2023
1b04de3
update
Apr 23, 2023
f0832d9
update
Apr 23, 2023
b7b41df
update
Apr 23, 2023
355264d
update
Apr 23, 2023
cd004fa
update
Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lightning/app/core/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@


def get_lightning_cloud_url() -> str:
# detect local development
if os.getenv("VSCODE_PROXY_URI", "").startswith("http://localhost:9800"):
return "http://localhost:9800"
tchaton marked this conversation as resolved.
Show resolved Hide resolved
# DO NOT CHANGE!
return os.getenv("LIGHTNING_CLOUD_URL", "https://lightning.ai")

Expand Down
11 changes: 1 addition & 10 deletions src/lightning/app/storage/path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,16 +427,7 @@ def _filesystem() -> AbstractFileSystem:
endpoint_url = os.getenv("LIGHTNING_BUCKET_ENDPOINT_URL", "")
bucket_name = os.getenv("LIGHTNING_BUCKET_NAME", "")
if endpoint_url != "" and bucket_name != "":
key = os.getenv("LIGHTNING_AWS_ACCESS_KEY_ID", "")
secret = os.getenv("LIGHTNING_AWS_SECRET_ACCESS_KEY", "")
# TODO: Remove when updated on the platform side.
if key == "" or secret == "":
key = os.getenv("AWS_ACCESS_KEY_ID", "")
secret = os.getenv("AWS_SECRET_ACCESS_KEY", "")
if key == "" or secret == "":
raise RuntimeError("missing S3 bucket credentials")

fs = S3FileSystem(key=key, secret=secret, use_ssl=False, client_kwargs={"endpoint_url": endpoint_url})
fs = S3FileSystem()
ethanwharris marked this conversation as resolved.
Show resolved Hide resolved

app_id = os.getenv("LIGHTNING_CLOUD_APP_ID", "")
if app_id == "":
Expand Down