Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forgotten change logs #1380

Merged
merged 3 commits into from
Apr 5, 2020
Merged

add forgotten change logs #1380

merged 3 commits into from
Apr 5, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 4, 2020

What does this PR do?

Fixes #1149 #1357 #1365 #1358 and many more

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label Apr 4, 2020
@Borda Borda added this to the 0.7.2 milestone Apr 4, 2020
@mergify mergify bot requested a review from a team April 4, 2020 19:43
@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #1380 into master will not change coverage by %.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1380   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          63      63           
  Lines        3317    3317           
======================================
  Hits         3042    3042           
  Misses        275     275           

@Borda Borda marked this pull request as ready for review April 4, 2020 20:15
@Borda Borda added the ready PRs ready to be merged label Apr 4, 2020
@Borda Borda requested a review from a team April 5, 2020 09:53
@williamFalcon williamFalcon merged commit fdcf9cd into master Apr 5, 2020
@Borda Borda deleted the docs/changelog branch April 5, 2020 17:55
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
* forgot change logs

* more missing

* more missing
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants