Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wandb): save models on wandb #1339

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

borisdayma
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

This PR allows to save checkpoints in wandb directory which is uploaded at the end of the script. See example

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 2, 2020 03:47
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #1339 into master will decrease coverage by 0%.
The diff coverage is 67%.

@@          Coverage Diff           @@
##           master   #1339   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files          62      62           
  Lines        3239    3242    +3     
======================================
+ Hits         2966    2968    +2     
- Misses        273     274    +1     

@williamFalcon
Copy link
Contributor

awesome!

@williamFalcon williamFalcon merged commit 6b41b5c into Lightning-AI:master Apr 2, 2020
@Borda Borda added the feature Is an improvement or enhancement label Apr 2, 2020
@Borda Borda added this to the 0.7.2 milestone Apr 2, 2020
alexeykarnachev pushed a commit to alexeykarnachev/pytorch-lightning that referenced this pull request Apr 3, 2020
* feat(wandb): save models on wandb

* docs(changelog): allow to upload models on W&B
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants