Check parallel_devices passed through strategy is consistent with the accelerator flag
#12105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
four4fish
requested review from
tchaton,
SeanNaren,
carmocca,
Borda,
williamFalcon,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
ananthsub
approved these changes
Feb 25, 2022
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
carmocca
approved these changes
Feb 28, 2022
ananthsub
reviewed
Feb 28, 2022
ananthsub
reviewed
Mar 1, 2022
awaelchli
reviewed
Mar 6, 2022
| self._accelerator_flag = "cpu" | ||
| if self._strategy_flag.parallel_devices[0].type == "cuda": | ||
| if self._accelerator_flag and self._accelerator_flag not in ("auto", "gpu"): |
There was a problem hiding this comment.
when possible, we should always try optimize for minimum number of indentations to improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11449 follow up items
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃