Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_distributed to Strategy API and remove accl_conn is_distributed property #11968

Closed
wants to merge 1 commit into from

Conversation

four4fish
Copy link
Contributor

What does this PR do?

Fixes #11449 TODO item, remove unused properties

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the 1.6 milestone Feb 18, 2022
@ananthsub
Copy link
Contributor

It seems like the only place inside of Lightning that needs this property is the data connector. I feel #11756 is a better solution for handling the distributed sampler compared to requiring every property to declare whether it's distributed or not

@four4fish
Copy link
Contributor Author

It seems like the only place inside of Lightning that needs this property is the data connector. I feel #11756 is a better solution for handling the distributed sampler compared to requiring every property to declare whether it's distributed or not

@ananthsub LightningLite is depending on this as well

@ananthsub
Copy link
Contributor

@ananthsub LightningLite is depending on this as well

Lite relies on it for setting up dataloaders, which is exactly why this logic should be put into the strategy. it's still the same feature request. Lite can directly depend on the strategy for process_dataloader.

@four4fish
Copy link
Contributor Author

@ananthsub LightningLite is depending on this as well

Lite relies on it for setting up dataloaders, which is exactly why this logic should be put into the strategy. it's still the same feature request. Lite can directly depend on the strategy for process_dataloader.

Oh I see! That make sense, will abandon this PR then. Let's do the #11756 way

@four4fish four4fish closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Accelerator_connector and follow up tasks
3 participants