You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we use the basic mlflow logging via with mlflow.start_run(): ... context manager, we get a better supplementary info about the run (git commit sha, user, filename) rendered in the Tracking UI (system tags)
But when we use MLFlowLogger as a logger in pytorch_lightning, this info is not logged. As a user, I'd like to have a mirrored functionality out-of-the-box.
I inspected the start_run() method of mlflow and deduced that the only thing is left while creating the run via MLflowClient is to add resolve_tags from the context package:
I think it's a better idea to add those tags internally (meaning not to expect users doing that manually) as first - it's as seamless as in the default API, secondly - it's the pytorch_lightning that manages the mlflow's run anyways.
PR is following ...
The text was updated successfully, but these errors were encountered:
* Update mlflow.py
#6745 adds additional info about the run, as in the native API
* Update mlflow.py
trying to fix some backward compatibility issues with `resolve_tags`
* wip on backward compatibility
added a default for `getattr` in case the `registry` object exists, but has no proper attribute (weird case but who knows...)
* fix pep
* impoert
* fix registry import
* try fix failing tests
removed the first if statement, so that `resolve_tags` would be defined either case
* fix formatting
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
🐛 Bug
When we use the basic mlflow logging via
with mlflow.start_run(): ...
context manager, we get a better supplementary info about the run (git commit sha, user, filename) rendered in the Tracking UI (system tags)But when we use
MLFlowLogger
as a logger in pytorch_lightning, this info is not logged. As a user, I'd like to have a mirrored functionality out-of-the-box.I inspected the
start_run()
method of mlflow and deduced that the only thing is left while creating the run via MLflowClient is to addresolve_tags
from thecontext
package:I think it's a better idea to add those tags internally (meaning not to expect users doing that manually) as first - it's as seamless as in the default API, secondly - it's the pytorch_lightning that manages the mlflow's run anyways.
PR is following ...
The text was updated successfully, but these errors were encountered: