fix test

pytorch_lightning/profiler/profilers.py

@@ -152,10 +152,15 @@ def log_row(action, mean, total):
         output_string += os.linesep
         return output_string
 
+    def describe(self):
+        """Logs a profile report after the conclusion of the training run."""
+        super().describe()
+        if self.output_file:
+            self.output_file.flush()
+
     def __del__(self):
         """Close profiler's stream."""
         if self.output_file:
-            self.output_file.flush()
             self.output_file.close()
 
 
@@ -214,8 +219,13 @@ def summary(self) -> str:
 
         return output_string
 
+    def describe(self):
+        """Logs a profile report after the conclusion of the training run."""
+        super().describe()
+        if self.output_file:
+            self.output_file.flush()
+
     def __del__(self):
         """Close profiler's stream."""
         if self.output_file:
-            self.output_file.flush()
             self.output_file.close()

pytorch_lightning/trainer/trainer.py

@@ -489,10 +489,10 @@ def get_init_arguments_and_types(cls) -> List[Tuple[str, Tuple, Any]]:
              ('print_nan_grads', (<class 'bool'>,), False),
              ('process_position', (<class 'int'>,), 0),
              ('profiler',
-              (<class 'pytorch_lightning.profiler.profiler.BaseProfiler'>,
+              (<class 'pytorch_lightning.profiler.profilers.BaseProfiler'>,
                <class 'NoneType'>),
               None),
-            ...
+             ...
         """
         trainer_default_params = inspect.signature(cls).parameters
         name_type_default = []

tests/test_profiler.py

@@ -1,4 +1,4 @@
-import tempfile
+import os
 import time
 from pathlib import Path
 
@@ -30,8 +30,8 @@ def simple_profiler():
 
 
 @pytest.fixture
-def advanced_profiler():
-    profiler = AdvancedProfiler()
+def advanced_profiler(tmpdir):
+    profiler = AdvancedProfiler(output_filename=os.path.join(tmpdir, "profiler.txt"))
     return profiler
 
 
@@ -168,12 +168,9 @@ def test_advanced_profiler_describe(tmpdir, advanced_profiler):
     # record at least one event
     with advanced_profiler.profile("test"):
         pass
-    # log to stdout
+    # log to stdout and print to file
     advanced_profiler.describe()
-    # print to file
-    advanced_profiler.output_filename = Path(tmpdir, "profiler.txt")
-    advanced_profiler.describe()
-    data = Path(advanced_profiler.output_filename).read_text()
+    data = Path(advanced_profiler.output_fname).read_text()
     assert len(data) > 0