Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop custom CSV logger implementation #587

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 26, 2023

The custom implementation in this repo has the issue fixed in Lightning-AI/pytorch-lightning#18567

Since we no longer keep the full metrics history in memory and write it every time, it's not straightforward to do the aggregation by step on the go.

This PR removes it, the csv file can be post-processed after training with something like:

import pandas as pd
df = pd.read_csv('metrics.csv')
combined_df = df.groupby('step').sum()
print(combined_df)

@carmocca carmocca requested a review from awaelchli as a code owner September 26, 2023 20:19
@carmocca carmocca self-assigned this Sep 26, 2023
@carmocca carmocca requested a review from lantiga as a code owner September 26, 2023 20:19
@carmocca carmocca merged commit cc19015 into main Sep 26, 2023
@carmocca carmocca deleted the carmocca/drop-custom-csv-logger branch September 26, 2023 20:32
@carmocca carmocca assigned carmocca and unassigned carmocca Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant