Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip converting .safetensors to .bin #1853

Conversation

ysjprojects
Copy link
Contributor

Addresses #1625

Tested it locally on Qwen2.5-0.5b and it appears to work fine.

@ysjprojects
Copy link
Contributor Author

Hi, just checking if this PR will be pursued soon.

Copy link

gitguardian bot commented Dec 30, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Andrei-Aksionov Andrei-Aksionov force-pushed the skip-converting-.safetensors-to-.bin branch from 7b15b36 to a5a15dd Compare December 30, 2024 17:46
@Andrei-Aksionov
Copy link
Collaborator

Hey @ysjprojects

Hi, just checking if this PR will be pursued soon.

Yeah, I checked the PR.
And butchered it a lil bit in the process 🙃

I don't see anything wrong with it.
It doesn't increase the peak memory consumption. Looks like _lazy_load loads data, but also keeps previously loaded one in memory. So no disadvantages in loading .safetensors data right away.
The benefit is, of course, that we don't need to do the conversion.

Good job 👍

@Andrei-Aksionov Andrei-Aksionov enabled auto-merge (squash) December 30, 2024 17:58
@Andrei-Aksionov Andrei-Aksionov merged commit 470f14e into Lightning-AI:main Dec 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants