Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore SlimPajama preprocessing code #1840

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Restore SlimPajama preprocessing code #1840

merged 3 commits into from
Nov 28, 2024

Conversation

aflah02
Copy link
Contributor

@aflah02 aflah02 commented Nov 28, 2024

Rework of #1838

Andrei-Aksionov
Andrei-Aksionov reviewed Nov 28, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@aflah02 @Andrei-Aksionov
Update pyproject.toml
addd491 
Co-authored-by: Andrei-Aksionov <58434077+Andrei-Aksionov@users.noreply.github.com>
@aflah02
Copy link
Contributor Author

aflah02 commented Nov 28, 2024

Thanks @Andrei-Aksionov
It seems this is ready

@Andrei-Aksionov Andrei-Aksionov merged commit 3f28cd6 into Lightning-AI:main Nov 28, 2024
8 of 9 checks passed
@Andrei-Aksionov
Copy link
Collaborator

Thanks for the patience @aflah02

@aflah02
Copy link
Contributor Author

aflah02 commented Nov 28, 2024

haha thanks for helping me debug :)

@aflah02 aflah02 deleted the SlimPajama branch November 28, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrei-Aksionov Andrei-Aksionov Andrei-Aksionov left review comments

@rasbt rasbt Awaiting requested review from rasbt rasbt is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aflah02 @Andrei-Aksionov