-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for lightning 0.10.0 #264
Conversation
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
===========================================
- Coverage 85.66% 54.15% -31.51%
===========================================
Files 176 176
Lines 9388 9340 -48
===========================================
- Hits 8042 5058 -2984
- Misses 1346 4282 +2936
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@williamFalcon I think this one is close to being ok, but it seems full testing has been broken since #248 😢 . EDIT - ignore me...failing on unrelated issues |
self.hparams.encoder was renamed to self.hparams.encoder_name in a8e3fb5 Lightning-Universe#264 Rename overlooked occurrence as in 2163626 Lightning-Universe#680
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃