-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CU-86dth9nnd] add channel to surveys #164
[CU-86dth9nnd] add channel to surveys #164
Conversation
Task linked: CU-86dth9nnd Refactor Laravel Backend Architecture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just hardcode the channels instead of saving it on the store, it isn't necessary, no?
@@ -21,30 +23,31 @@ const flowsWithSmallFooter: FlowType[] = [ | |||
]; | |||
|
|||
export const CancerSurveyThankYou = () => { | |||
const { flow, email, phase } = useSurveyStore(); | |||
const { flow, email, phase, channel } = useSurveyStore(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why grab it from the store if we already know it's cancer? This is the CancerSurveyThankYou
component
|
||
export const SeniorSurveyThankYou = () => { | ||
const { email, phase } = useSurveyStore(); | ||
const { email, phase, channel } = useSurveyStore(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
channel?: Channel; | ||
|
||
setChannel(channel: Channel): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this
Light It Pull Request Template ⚡⚡⚡
Resolve: CU-86dth9nnd
feat: implement the channel in the survey screens
Checklist ✅