-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major redux refactor and file restructure #58
Conversation
|
If you wanna be super legit about Redux typing, it gets complicated That said I think VSCode flow integration is kinda broken right now for some reason, so it's difficult to see if any types I'm adding are working... =( |
Was running into some problems with Flow not starting in VSCode ^ that fixed one problem, but hover still doesn't seem to work for me =(((( I'm going to have to push off additional typing until after I get Flow fixed I've created an issue to track this #66 |
Installed react-redux 7.1.0-rc.1 for hooks. Need to update the version once a stable version is released Update redux to v7.1 stable #59
extract all selectors to their relevant duck
utilize reselect and re-reselect where relevant
replace all relative imports with absolute imports
look into getting router props into redux, is it helpful?Doesn't seem too useful right now, and even less so when react router supports hooksget rid of containers and utilize redux hooks
use Material-UI style hook where applicablenot worth the effort to refactor ALL components. But continue to use the hooks for any new code.get rid of Containers and Pages
move selectors and dispatch down to lower components where relevantcreated Move selectors and dispatch down to lower components where relevant #67 to track thisrename(redux taken, can't think of a better name right now)redux-ducks
to justredux
add typing for the entire state objectadd typing for redux actions?add typing for selectors?closes #50, closes #51, closes #53