Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Showing keyboard shortcuts on file menu #176

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

ctw-joao-luis
Copy link
Collaborator

User-Facing Changes

Keyboard shortcuts for the file menu options: Open local file and Open connection are now visible

Description

Made it so the keyboard shortcuts are now visible to the user, checking what kind of system the user is currently using and changing the shortcut whether they're using Mac or Win/Linux;

Also made it so letter case is ignored when using shortcuts, something that wasn't implemented until now.

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests

@ctw-joao-luis ctw-joao-luis added the enhancement New feature or request label Sep 11, 2024
@ctw-joao-luis ctw-joao-luis changed the title Feature/showing shortcuts on menu [Feature] Showing keyboard shortcuts on file menu Sep 11, 2024
Copy link
Collaborator

@aneuwald-ctw aneuwald-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats for your first PR 🎉

@ctw-joao-luis ctw-joao-luis merged commit 2071986 into main Sep 11, 2024
8 checks passed
@ctw-joao-luis ctw-joao-luis deleted the feature/showing-shortcuts-on-menu branch September 11, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants