New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Replace React.DOM render with createRoot #174

Merged

luluiz merged 11 commits into main from fix/replace-reactdom-render-with-createroot

Sep 11, 2024

Member

luluiz commented Sep 9, 2024 •

edited

Loading

User-Facing Changes

N/A

Description
It was removed from the deprecated React.DOM and replaced by createRoot.
It removed StrictMode as it caused duplicate execution in the application's dialog.

Checklist

The web version was tested and it is running ok
The desktop version was tested and it is running ok

luluiz added 2 commits

September 9, 2024 09:47


          createRoot and removed strictmode

6fafbf3

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>


          removed all strictmode

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>

luluiz changed the title ~~Fix/replace reactdom render with createroot~~ [FIX] Replace React.DOM render with createRoot

luluiz added the bug label


          Fixed lint issues

797fd55

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>

laisspportugal requested changes

View reviewed changes

Collaborator

laisspportugal left a comment

There is an error when running the web application when using this branch.
Can you please take a look on that?

luluiz added 4 commits

September 10, 2024 15:42


          fixed NaN height for the PathLegend css component

5132daf

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>


          unmounted safely

bfb797b

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>


          used queueMicroTask to wait next cycle to send init request to the wo…

031f32c

…rker

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>


          fixed lint issues

5dacc44

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>

Member Author

luluiz commented Sep 10, 2024 •

edited

Loading

There is an error when running the web application when using this branch. Can you please take a look on that?

Since we started using the concurrent model applied by React's createRoot, I needed to adapt the Chart component's update behaviour to wait for the next cycle using queueMicrotask, which has better performance than setTimeout in this type of scenario.

luluiz added 3 commits

September 10, 2024 18:18


          fixed unit test to unmount component

f5c5e3a

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>


          fixed lint issues

9ca4bc4

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>


          removed deplicated imports

8d7d926

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>

aneuwald-ctw reviewed

View reviewed changes

packages/suite-base/src/panels/createSyncRoot.test.tsx Outdated Show resolved Hide resolved


          used queueMicrotask to test unmount components

44ecdd5

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>

aneuwald-ctw approved these changes

View reviewed changes

Collaborator

aneuwald-ctw left a comment

LGTM. Liked the "queueMicrotask"

laisspportugal approved these changes

View reviewed changes

luluiz merged commit aaba18d into main

8 checks passed

luluiz deleted the fix/replace-reactdom-render-with-createroot branch

September 11, 2024 17:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug