Update RUN.md #84
Merged
Update RUN.md #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove non-existent dependency on db service (acme) that causes error when running docker-compose
colisee
reviewed
Dec 22, 2023
| @@ -162,7 +162,6 @@ services: | |||
| restart: always | |||
| depends_on: | |||
| - proxy | |||
There was a problem hiding this comment.
Thank you for your PR. You are totally right: the dependency to acme must be removed.
But I also think that the proxy dependency on the line just above should be renamed to rproxy to match the service name associated with traefik.
Could you please check and make the final change, if applicable?
There was a problem hiding this comment.
True! I also had a problem with this R
colisee
requested changes
Dec 22, 2023
replace rproxy with proxy on line 137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove non-existent dependency on db service (acme) that causes error when running docker-compose