Versioning, Tests, fixes and updates #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be willing to accept a further PR for a GitHub Actions template that runs all the tests periodically automatically? |
|
Hi, Thanks again for these! All look great. And no problem on a GitHub Action. Maybe not run every day, just to ensure it doesn't use up too many of the included free minutes, but otherwise should be fine. I can always keep an eye on how long a single run takes from within GitHub. Dave |
|
Oh, and in other news, I know Durham are procuring for a new Library Management System, so presuming they go for one of the major suppliers, that will remove one connector. But those projects tend to take a year or so so I'm not expecting it any time very soon. A shame to lose one independent system really! |
DaveBathnes
pushed a commit
that referenced
this pull request
Mar 12, 2023
Haringey has moved to Enterprise (#23)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mixed bag of fixes and changes since many of the tests were failing since they were originally written. All tests now pass.
Versioning
Arena and Koha now have versioned implementation classes. This has reduced the amount of config required for each service in
data.json(e.g. portlet vs portlets for Arena, etc). Version numbers of the library systems have been discovered through HTTP headers or HTML<head>information.I'm surmising - though don't know for sure - that these two platforms are self-hosted and that will explain the variance in deployed versions, whereas others are SaaS products which will generally be kept up-to-date.
Library listings
No libraries have hard-coded values anymore; all are discovered using code.
The list of common "non-library" terms has also been updated to add some new values that have popped up since the code was originally written.
It also now requires an exact (but case-insensitive) match on the trimmed value since it was removing some items as false-positives previously.
Prism
Change in domain name here - the old Capita Discovery one is no longer maintained and has an expired SSL certificate.
Tests
Tests now:
getLibrariescalls;Fixes were made where tests failed (which is where the majority of changes in this PR originate from).
Libraries changing platform
Some libraries have switched between providers and
data.jsonhas been updated accordingly: