Bury to Spydus; Luci tests require VPN #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bury
Has moved to Spydus.
data.json
updated and test passes.Test automation and Luci
The problem
We've hit a bit of a problem with the tests for Luci. They've failed the last two weeks but worked fine on my computer. My theory was that connections from outside the UK are being blocked by their servers, and I've now confirmed that by trying to run the tests when connected to a VPN to the US.
It's not possible to choose a region to run a GitHub Action in. All GitHub's servers are in the US.
Updates to the Action
I've updated the YAML file for the GitHub action so it launches an OpenVPN connection to a server prior to the tests running. The URL for the connection profile, the username and the password can be stored as secrets in the repository's configuration. For my fork of the repo, I'm using my Express VPN credentials to access their UK server prior to running the tests. The Luci tests do now pass.
Ways forward
Unfortunately, this has added a bit of complexity to something that really ought to be far more straightforward!
Since I'd rather not share my ExpressVPN credentials (sorry!), I guess there are the following ways forward:
Also open to other ideas..!