Fix Sectigo intermediary certificate issue #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpwood
referenced
this pull request
in cpwood/catalogues-library
Aug 21, 2022
Merge pull request #16 from cpwood/main
DaveBathnes
pushed a commit
that referenced
this pull request
May 21, 2023
Merge pull request #38 from cpwood/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knowsley libraries failed on Friday's CI run and this was because its SSL certificate had changed. The error was an
UNABLE_TO_VERIFY_LEAF_SIGNATUREerror when connecting to the server.I checked the SSL certificate for the server with SSL Labs and it confirmed that the certificate chain is incomplete:
We've also had other libraries that have encountered this issue, which is why a
DisableTlsoption was included withindata.json.The missing intermediary public certificate is now included within the repo and is injected into Node JS when the code is run. This makes Knowsley work again, as well as the other libraries where
DisableTlswas previouslytrue.Dependencies have also been updated.