Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test ISBNs have now been removed from the
data.json
file and from the individual test invocations. Instead, they are now looked up fromtests.json
.For each library service, five ISBNs are defined. In the vast majority of cases, these are the ISBN numbers for:
Where a library doesn't have one of the above books, a similar book has been substituted. These are generally "The Complete Works of Shakespeare" and "Gangsta Granny Strikes Again".
The tests require only one of these books to be found. This will hopefully prevent weekly test failures as much as possible where the root cause is a book dropping out of circulation rather than a software problem. There should always be another book to which the tests can fall back.
At the time of these changes, the following library services were excluded: