Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New approach for tests #11

Merged
merged 3 commits into from
Jun 7, 2022
Merged

New approach for tests #11

merged 3 commits into from
Jun 7, 2022

Conversation

cpwood
Copy link
Contributor

@cpwood cpwood commented Jun 5, 2022

Test ISBNs have now been removed from the data.json file and from the individual test invocations. Instead, they are now looked up from tests.json.

For each library service, five ISBNs are defined. In the vast majority of cases, these are the ISBN numbers for:

  1. Harry Potter and the Philosopher's Stone - J K Rowling
  2. Nineteen Eighty Four - George Orwell
  3. Pride and Prejudice - Jane Austen
  4. Hamlet - William Shakespeare
  5. Gangsta Granny - David Walliams

Where a library doesn't have one of the above books, a similar book has been substituted. These are generally "The Complete Works of Shakespeare" and "Gangsta Granny Strikes Again".

The tests require only one of these books to be found. This will hopefully prevent weekly test failures as much as possible where the root cause is a book dropping out of circulation rather than a software problem. There should always be another book to which the tests can fall back.

At the time of these changes, the following library services were excluded:

  • Bexley - ongoing issues getting availability searches to work because of cookie requirements;
  • Falkirk - catalogue issues - availability lookups are timing out and failing.

@DaveBathnes DaveBathnes merged commit 8d1a306 into LibrariesHacked:main Jun 7, 2022
cpwood referenced this pull request in cpwood/catalogues-library Jun 9, 2022
Merge pull request #11 from cpwood/main
DaveBathnes pushed a commit that referenced this pull request Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants