Update index.ts to support RLE_DICTIONARY #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
approved these changes
Jan 18, 2024
| @@ -1,5 +1,5 @@ | |||
| export * as PLAIN from './plain' | |||
| export * as RLE from './rle' | |||
| export * as PLAIN_DICTIONARY from './plain_dictionary' | |||
|
|
|||
| export * as RLE_DICTIONARY from './plain_dictionary' | |||
There was a problem hiding this comment.
Turns out the plain_dictionary has support for both!
Comment on lines
+193
to
+194
| // Tracked in https://github.com/LibertyDSNP/parquetjs/issues/113 | ||
| it.skip('rle_boolean_encoding.parquet loads', async function() { |
There was a problem hiding this comment.
Added this in a separate issue as it still fails.
test/test-files.js
Outdated
Comment on lines
200
to
208
| it('rle-dict-snappy-checksum.parquet loads', async function() { | ||
| const data = await readData('rle/rle-dict-snappy-checksum.parquet'); | ||
| assert.deepEqual(data[0],{ binary_field: "c95e263a-f5d4-401f-8107-5ca7146a1f98", long_field: 0 }); | ||
| }); | ||
|
|
||
| it('rle-dict-uncompressed-corrupt-checksum.parquet loads', async function() { | ||
| const data = await readData('rle/rle-dict-uncompressed-corrupt-checksum.parquet'); | ||
| assert.deepEqual(data[0],{ binary_field: "6325c32b-f417-41aa-9e02-9b8601542aff", long_field: 0 }); | ||
| }); |
There was a problem hiding this comment.
Reference files from https://github.com/apache/parquet-testing work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
problem statement - when trying to read a parquet file that was generated using V2 parquet and had RLE_DICTIONARY, got an error: invalid encoding: RLE_DICTIONARY #96
Reported issue: #96
Solution
What I/we did to solve this problem
added: export * as RLE_DICTIONARY from './plain_dictionary';
with @pairperson1
Change summary:
Steps to Verify:
I added this line to an existing project in the node modules and it works. without this line I get an an error with this line added - it passed