Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Support composer.lock in sub directory of git repository #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thommyhh
Copy link

Determine path of composer.lock relative to git root directory to
correctly get HEAD version of composer.lock.

Determine path of `composer.lock` relative to git root directory to
correctly get HEAD version of `composer.lock`.
@thommyhh
Copy link
Author

@markus-k Don't know, if you're still using or maintaining this.

In my current setups the composer.lock is located in a sub directory of the git repository. The current version assumes, that it is directly in the git repository root, leading to an error.

@markus-k
Copy link
Contributor

I haven't touched PHP in years, so no. Maybe @thomashempel is still using it?

@thommyhh
Copy link
Author

@markus-k Can you update it anyway or transfer the NPM package to me. If Thomas doesn't use/want to maintain it.

@markus-k
Copy link
Contributor

I don't have write access to this repository anymore, so I can't do much.

@thommyhh
Copy link
Author

@markus-k I don't want the repo, I already made a fork. I want the NPM package on NPMJS.org. It says, you're the only contributer.

@markus-k
Copy link
Contributor

Oh! Well I would, but my account seems broken. Password reset results in Service Unavailable...

@markus-k
Copy link
Contributor

BTW, it's still broken.

@thommyhh
Copy link
Author

@markus-k What do you mean by "broken"? If you can't enter a generated password, try removing symbols from the password. I've had diffculties with symbols in password on several sites.

@markus-k
Copy link
Contributor

I was finally able to reset my password, I added you as a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants