Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasm_of_ocaml uses a different representation for OCaml floats and JavaScript numbers, so we need explicit coercions (which are still optimized away by Js_of_ocaml).
Also, since JavaScript values get boxed, physical equality can no longer be used to test whether a value is
undefined
.But as
undefined == null
, I have just simplified the test inoption_of_js
.The WebAssembly implementation of the runtime functions
caml_ojs_wrap_fun_arguments
andcaml_ojs_iterate_properties
is provided bywasm_of_ocaml
.