Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update and fix standard #22

Merged
merged 2 commits into from
Apr 3, 2021
Merged

fix: update and fix standard #22

merged 2 commits into from
Apr 3, 2021

Conversation

ronag
Copy link
Contributor

@ronag ronag commented Mar 7, 2021

No description provided.

@vweevers
Copy link
Member

vweevers commented Mar 7, 2021

This is semver-major due to reduced browser support, I'm cool with that.

Note that messagea.js is generated code, so perhaps we should exclude it from standard (--fix).

@vweevers vweevers added the semver-major Changes that break backward compatibility label Mar 7, 2021
@vweevers
Copy link
Member

vweevers commented Mar 7, 2021

@ronag Do you foresee other breaking changes or should I go ahead and release a new major?

@ronag
Copy link
Contributor Author

ronag commented Mar 7, 2021

@ronag Do you foresee other breaking changes or should I go ahead and release a new major?

I don't have any further plans at the moment.

@vweevers
Copy link
Member

vweevers commented Mar 7, 2021

OK. Will release tomorrow; giving it some time in case someone is using this in browsers and has objections.

@vweevers vweevers merged commit e7c67e2 into Level:master Apr 3, 2021
@vweevers
Copy link
Member

vweevers commented Apr 3, 2021

4.0.0 (apologies for the delay).

@vweevers vweevers mentioned this pull request Apr 4, 2021
Closed
83 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
semver-major Changes that break backward compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @vweevers