Allow function as default value for parsing empty tags #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 21, 2019 19:06
In case there are multiple empty tags in xml, they all share reference to the same default object. This causes unwanted duplication, when we assign something to any of these empty objects. When we provide factory function for emptyObject, these objects no longer share reference and works as expected.
|
@Leonidas-from-XIV can you please merge this PR |
|
@honzas can you please add description of this new feature to README.md |
|
@honzas sorry for latter plea. can you please add to emptyTag callback param of current value of tag. often ' ' (space) ignored by xml2js and 2 neighbor words collapsed |
|
@ozknemoy not sure what you mean - could you give me an example? |
|
@honzas sorry ... dig deeper into code and understood that its not the case |
|
Thanks, looks good to me and a sensible solution to the problem of shared mutable references. Sorry for the long silence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now specify empty object as default value when parsing xml. This empty object is then shared as a reference across all occurences - when we assign something to it, new value appears in all default empty objects (we don't want that).
By specifying function as default value for empty object, we can provide factory function which creates new empty object for each occurence individually.