fix(linux): off by one error caused list_afinet_netifas to omit the last ip address
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoBorai
changed the title
list_afinet_netifas to omit the last ip address
|
@D1plo1d nice work! |
|
What a coincidence! We must have both discovered this error at a similar time (see 3524c0b) 🙂 |
cgzones
added a commit
to cgzones/local-ip-address
that referenced
this pull request
Feb 27, 2023
Rewrite the Linux version of list_afinet_netifas() using netlink requests in pure Rust instead of calling the libc interface getifaddrs(3). This avoids pointer magic and calling unsafe C code. See LeoBorai#88 and LeoBorai#93 for exemplary issues.
cgzones
added a commit
to cgzones/local-ip-address
that referenced
this pull request
Feb 27, 2023
Rewrite the Linux version of list_afinet_netifas() using netlink requests in pure Rust instead of calling the libc interface getifaddrs(3). This avoids pointer magic and calling unsafe C code. See LeoBorai#88 and LeoBorai#93 for exemplary issues.
cgzones
added a commit
to cgzones/local-ip-address
that referenced
this pull request
Feb 28, 2023
Rewrite the Linux version of list_afinet_netifas() using netlink requests in pure Rust instead of calling the libc interface getifaddrs(3). This avoids pointer magic and calling unsafe C code. See LeoBorai#88 and LeoBorai#93 for exemplary issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the Linux implementation where a
whilecondition checked if the next item (ifa_next) would be null before it consumed the current item (ifa). This caused the loop to always skip the last ip address, causing it to be omitted from the list returned bylist_afinet_netifas().