Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: use correct message types for requests #121

Merged
merged 1 commit into from
May 5, 2023

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented May 5, 2023

Commit 109ff03 ("feat(linux): rewrite list_afinet_netifas (#103)") used the wrong message types for requests, while using the correct ones for responses. According to rtnetlink(7) RTM_GETLINK messages use the type ifinfomsg and RTM_GETADDR messages use the type ifaddrmsg.

Fixes: 109ff03 ("feat(linux): rewrite list_afinet_netifas (#103)")

Replaces: #120

Commit 109ff03 ("feat(linux): rewrite list_afinet_netifas (LeoBorai#103)") used
the wrong message types for requests, while using the correct ones for
responses.  According to rtnetlink(7) RTM_GETLINK messages use the type
ifinfomsg and RTM_GETADDR messages use the type ifaddrmsg.

Fixes: 109ff03 ("feat(linux): rewrite list_afinet_netifas (LeoBorai#103)")
Copy link
Owner

@LeoBorai LeoBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@LeoBorai LeoBorai merged commit 5d606b6 into LeoBorai:main May 5, 2023
@cgzones cgzones deleted the message_fixup branch May 5, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants