fix: trim Unexpected \0 in network interface name
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoBorai
changed the title
\0 in network interface name
LeoBorai
reviewed
Mar 10, 2023
src/linux.rs
Outdated
Comment on lines
368
to
378
| fn parse_ifname(bytes: &[u8]) -> Result<String, Error> { | ||
| let ifname = CStr::from_bytes_with_nul(bytes) | ||
| .map_err(|_| { | ||
| Error::StrategyError(String::from( | ||
| "An error occurred convert interface name to string", | ||
| )) | ||
| })? | ||
| .to_string_lossy() | ||
| .to_string(); | ||
| Ok(ifname) | ||
| } |
There was a problem hiding this comment.
Looks good, can we have some unit tests on this please?
I believe by having:
- Case where
\0instances are filtered - Case where text without
\0is not affected
Would be nice!
There was a problem hiding this comment.
Ok, I'll add some more unit tests
|
Thanks so much @bitcapybara! |
LeoBorai
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #110 ：This pr tries to solve the problem raised by issue #110 ，all network interface names returned by the list_afinet_netifas() method contained an unexpected '\0', I try to use
CStrto trim the '\0' of the suffix in this pr.