Personal space

Summary

• Added personal space to view personal information and change login credentials
• Added a dark theme
• Improved safety of coupled database requests

Complete changelog

Added

• Light and dark themes
• Transaction wrapping for coupled requests
• Personal space
  • Display personal info
  • Change password
  • Change email
  • Delete account
• Testing
  • Unit tests
    • Locale setting
    • Session settings (locale and theme)
    • Auth pages access
    • Auth requests
    • "Change email" request and validation
    • "Change password" request and validation
    • "Delete account" request and validation
    • Access to account page browser test
    • Account page browser tests
  • Feature tests
    • Account deletion
    • Email change
    • Password change

Changed

• Views
  • Made home footer a common footer for every page
• Updated dependencies

Fixed

• Typos in some testing functions names and comments
• Typo in README file

Dependencies cleanup

Summary

• Removed and replaced some dependencies
• Added some new validation rules

Complete changelog

Added

• Validation rules
  • New borrowing
    • The expected return date can be at most one month away.
  • Delete user
    • The user must not be involved in an ongoing borrowing.

Changed

• Environment
  • Moved public folder content to resources
  • Replaced Bootstrap with Bulma
  • Removed jQuery
  • Replaced flag-icon-css with a custom lighter build
  • Removed @babel/polyfill

Browser features testing

Summary

• Added feature tests
  • These tests assert that users manage to perform actions they intend to through a web navigator
• Enabled password resetting and improved relevant views
• Improved some views' tags hierarchy
• Fixed security issue

Complete changelog

Added

• Testing
  • Dusk setup
  • Unit tests
    • For pages visits
    • For pages accesses from home page
    • For pages interactions
  • Feature tests
    • Perform new borrowing
    • Retrieve borrowing
    • Add new inventory item
    • Patch inventory item
    • Delete inventory item
    • Patch user
    • Delete user
• Factories
  • Added late and onTime states to borrowing factory
• Password resetting
  • Added authorization for users
• Validation
  • Added maximal value for borrowing guarantee
• Views
  • Home view
    • Added ids to buttons
  • End borrowing view
    • Added buttons blocking when no borrowing is selected
  • Borrowings history view
    • Added more selection tags
  • Edit inventory view
    • Changed redirection when completing action
  • Edit users view
    • Added more tags
    • Changed redirection when modifying own role
  • Passwords views
    • Added header
• TODO list
  • Moved TODO items to their own file
  • Added new TODO items
• Readme
  • Basic use guide

Changed

• New borrowing view
  • Inventory item buttons behaviour
• Password reset email
  • Improved template translation
• Testing
  • Made test classes attributes private
  • Refactored "New borrowing" and "End borrowing" requests tests
• Misc
  • Improved readability of PHP strings concatenations

Fixed

• Borrowing factory
  • The start date was mutated to generate the other dates
• Views
  • Borrowings history view
    • "Deleted user" message wasn't in translation files
  • Edit inventory view
    • Fixed tags hierarchy
    • Fixed "Remove genre" buttons listeners
• Redirections
  • Fixed redirections in "Reset password" and "Verification" controllers
• Security
  • Prevented javascript injections when adding text to database

Requests unit testing

Summary

• Added unit tests for requests
  • These tests assert that a valid request results in expected database operations
• Wrote a better readme file along with its french translation

Complete changelog

Added

• Readme
  • General presentation.
  • French version.
  • Link to license file.
• Validation
  • New borrowing
    • Rules for notes field.
• Testing
  • Unit tests for notes field rules of new borrowing request.
  • New borrowing request.
  • End borrowing request.
  • Add inventory item request.
  • Patch inventory item request.
  • Delete inventory item request.
  • Patch user request.
  • Delete user request.

Changed

• Edit user request
  • Renamed to Patch user request in controller, tests and language files.

Removed

• Testing
  • Useless (and incorrect) namespace for unit tests.

Authorization and validation unit testing

Summary

• Added unit testing for authorizations and requests validation.
• Created model factories.
• Refactored validation rules and "End borrowing" routing.

Complete changelog

Added

• Routing
  • Redirection to 401 error page for non-GET requests made by guests.
• Testing
  • Pages access tests.
  • Requests authentication tests.
  • New borrowing validation tests.
  • End borrowing validation tests.
  • Add inventory item validation tests.
  • Delete inventory item validation tests.
  • Patch inventory item validation tests.
  • Edit user validation tests.
  • Delete user validation tests.
• Models factories
  • Users.
  • Inventory items.
  • Borrowing.
  • Genre.
• Validation
  • General
    • Custom messages for integers in arrays validation.
    • bail validation rule for fields with custom validations rules.
    • Reworded some custom messages.
    • Inverted order of exist and distinct rules to prevent errors in replacers.
  • Register
    • Promotion must now be within an acceptable range.
  • New borrowing
    • Existence rule for borrowed items.
  • End borrowing
    • New custom rule to check if a borrowing to end isn't already declared as finished.
  • Add inventory item
    • Check uniqueness of names in database.
  • Patch inventory item
    • Check type of names.
    • Check uniqueness of names in database.
• TODO items
  • Usage of before and after borrowing notes.
  • Add confirmation modal when editing own role in "Edit users".

Changed

• End borrowing routes
  • HTTP verb POST to PATCH.
  • Refactored the two previously-POST routes to one.
• Validation
  • General
    • Simplified some custom validators thanks to bail rule addition for relevant fiels.
  • New borrowing
    • Simplified regex validation for guarantee.
  • Add inventory item
    • Improved validation rules.
  • Patch inventory item
    • Improved validation rules.

Fixed

• New borrowing
  • Start date of the borrowing.
    • Problem : The app doesn't correctly handle delayed borrowings as it is setting the items as borrowed when creating the borrowing regardless of the start date.
    • Solution : Forbid having a start date different from the current date when creating a borrowing.
    • Implementation : Remove the field from the form and update its related model attribute setting, validation rules and translation files.
  • Error in custom validator InventoryItemAvailable.
    • Problem : When a non-integer is fed to the validator, an error is thrown when trying to find the corresponding inventory item.
    • Solution : Prevent non-integers from being fed to the validator.
    • Implementation : Add bail rule to relevant field in NewBorrowingRequest.
  • Inventory item name not being displayed in InventoryItemAvailable error message.
• Edit inventory view
  • Typo in deletion warning message.
  • Line breaks in deletion warning message.
  • Error not displayed for "Players max" field when patching.
• Validators
  • Made the type conversions symmetrical in UnchangedDuringBorrowing validator.
• Changelog
  • Dates from the future. (Thanks Spooktober)

Edit users page

Summary

Added the "Edit users" page.

Complete changelog

Added

• End borrowing validation
  • A user can't confirm the return of its own borrowings.
• Edit inventory view
  • Minimal width of tables for better responsiveness.
• Edit users view
  • Layout.
  • Errors displaying.
• Edit users controller
  • Users updating and deletion.
• Edit users validation
  • Check for admin self-modification.

Removed

• Edit inventory view
  • Hiding of some elements for small viewports.