-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KON-343 KoDeclaration Add KDoc Support #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nataliapeterwas
commented
Apr 26, 2023
- Add koDoc property to KoDeclaration and test fot this
- Add KoDoc class with tests
- add KoDeclaration.hasKoDoc and tests for this
- add withKoDoc and withoutKoDoc in KoDeclarationSequenceExt and tests for them
- fix spotless
- add KoValuedBlockTag and KoBlockTag and properties to KoDoc
- add tests snippet
- upd KoDeclaration tests
- add dokka to konsist
- add tests for KoDoc
- add KoDeclaration.hasKoDocWithTags and tests for this
- add extensions about KoDoc to KoDeclarationSequenceExt and tests for them
- fix spotless and detekt
nataliapeterwas
commented
Apr 26, 2023
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoDeclaration.kt
Outdated
Show resolved
Hide resolved
nataliapeterwas
commented
Apr 26, 2023
nataliapeterwas
commented
Apr 26, 2023
igorwojda
requested changes
Apr 26, 2023
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoValuedBlockTag.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoDoc.kt
Outdated
Show resolved
Hide resolved
...lemonappdev/konsist/core/declaration/kodeclaration/snippet/forclass/class-has-not-kdoc.kttxt
Outdated
Show resolved
Hide resolved
igorwojda
reviewed
Apr 26, 2023
igorwojda
reviewed
Apr 26, 2023
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoDoc.kt
Outdated
Show resolved
Hide resolved
igorwojda
reviewed
Apr 26, 2023
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoBlockTag.kt
Outdated
Show resolved
Hide resolved
igorwojda
reviewed
Apr 26, 2023
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoValuedBlockTag.kt
Outdated
Show resolved
Hide resolved
…iDeclarationSequenceExt.kt
…add-KDoc-support # Conflicts: # lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoBaseDeclaration.kt # lib/src/main/kotlin/com/lemonappdev/konsist/core/ext/KoDeclarationSequenceExt.kt # lib/src/test/kotlin/com/lemonappdev/konsist/core/declaration/kobasedeclaration/KoBaseDeclarationTest.kt # lib/src/test/kotlin/com/lemonappdev/konsist/core/declaration/kopsideclaration/snippet/location-with-text.kttxt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.