Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layer package convention naming #1613

Merged

Conversation

BapNesS
Copy link
Contributor

@BapNesS BapNesS commented Dec 5, 2024

Accept camelCase regarding Kotlin guidelines:

Package and class naming rules in Kotlin are quite simple:

Names of packages are always lowercase and do not use underscores (org.example.project). Using multi-word names is generally discouraged, but if you do need to use multiple words, you can either just concatenate them together or use camel

https://kotlinlang.org/docs/coding-conventions.html#naming-rules

@BapNesS BapNesS force-pushed the update-layer-package-case-convention branch from e1fc884 to a466b40 Compare December 5, 2024 09:14
@BapNesS
Copy link
Contributor Author

BapNesS commented Dec 5, 2024

@igorwojda @nataliapeterwas Any reason why you choose to disabled camelCase in package naming convention ?

@igorwojda igorwojda changed the base branch from main to develop December 5, 2024 10:17
@igorwojda igorwojda merged commit ab35a75 into LemonAppDev:develop Dec 5, 2024
33 checks passed
@igorwojda
Copy link
Contributor

Thx for the contribution

@BapNesS BapNesS deleted the update-layer-package-case-convention branch December 5, 2024 11:18
igorwojda added a commit that referenced this pull request Dec 8, 2024
* Update plugin com.android.application to v8.7.3 (#1604)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update plugin com.android.library to v8.7.3 (#1605)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency com.lemonappdev:konsist to v0.17.1 (#1603)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update ktor monorepo to v3.0.2 (#1606)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency com.pinterest.ktlint:ktlint-cli to v1.5.0 (#1607)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Allow Layer consecutive dots in middle of package name

* Update dependency com.lemonappdev:konsist to v0.17.2 (#1612)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update layer package convention naming (#1613)

* Update layer package convention naming

Accept camelCase regarding Kotlin guidelines.
https://kotlinlang.org/docs/coding-conventions.html#naming-rules

* fix TU

* Update tj-actions/changed-files action to v45.0.5 (#1614)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Version to 0.17.3

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Baptiste Carlier <4005409+BapNesS@users.noreply.github.com>
@igorwojda
Copy link
Contributor

Released v0.17.3 https://github.com/LemonAppDev/konsist/releases/tag/v0.17.3 with this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants