Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KON-684 Add Asci Tree for declaration errors and SnippetTest #1521

Merged
merged 19 commits into from
Nov 22, 2024
Merged

KON-684 Add Asci Tree for declaration errors and SnippetTest #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e553e0c
add ascii tree to dclarations errors and hyperlinks instead of displa…
nataliapeterwas Nov 5, 2024
2d76e71
upd unused snippets test failure message
nataliapeterwas Nov 5, 2024
d9ec362
fix snippet test and remove unused snippets
nataliapeterwas Nov 5, 2024
d00c243
clean code
nataliapeterwas Nov 5, 2024
a26a2bf
extrack logic with hyperlinks to HyperlinkUtil
nataliapeterwas Nov 5, 2024
e985962
clean code
nataliapeterwas Nov 5, 2024
e092e8f
clean code
nataliapeterwas Nov 5, 2024
74dd6b8
rename asciiTreeNodes to failedDeclarationAsciiTreeNodes
nataliapeterwas Nov 6, 2024
58d963d
change format of declaration error message
nataliapeterwas Nov 6, 2024
c45938c
uppercase names in AsciiTreeNode
nataliapeterwas Nov 6, 2024
6f76168
update toHyperlink logic
nataliapeterwas Nov 13, 2024
983447a
add HyperlinkUtilTest
nataliapeterwas Nov 18, 2024
96f0798
fix integration tests
nataliapeterwas Nov 18, 2024
a045370
fix api tests
nataliapeterwas Nov 18, 2024
e2df61b
clean code
nataliapeterwas Nov 18, 2024
b775da5
add hyperlink to assert architecture error message
nataliapeterwas Nov 22, 2024
69c8daf
fix architecture message tests
nataliapeterwas Nov 22, 2024
37a654c
clean code
nataliapeterwas Nov 22, 2024
bda531a
clean code
nataliapeterwas Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 84 additions & 43 deletions ...om/lemonappdev/konsist/architecture/assertarchitecture/architecture2/Architecture2Test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,16 +239,19 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result
.message
.shouldBeEqualTo(
"'fails when dependency is set that domain layer is depend on presentation layer (parameter scope)' test has failed. \n" +
"Layer 'Domain' does not depends on 'Presentation' layer.\n" +
"'Presentation' layer should not depend on anything but has dependencies in files:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -266,17 +269,20 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result
.message
.shouldBeEqualTo(
"'fails when dependency is set that domain layer is depend on presentation layer (parameter files)' " +
"test has failed. \n" +
"Layer 'Domain' does not depends on 'Presentation' layer.\n" +
"'Presentation' layer should not depend on anything but has dependencies in files:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -297,17 +303,20 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result
.message
.shouldBeEqualTo(
"'fails when dependency is set that domain layer is depend on presentation layer (lambda scope)' " +
"test has failed. \n" +
"Layer 'Domain' does not depends on 'Presentation' layer.\n" +
"'Presentation' layer should not depend on anything but has dependencies in files:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -330,16 +339,20 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result
.message
.shouldBeEqualTo(
"'fails when dependency is set that domain layer is depend on presentation layer (lambda files)' " +
"test has failed. \n" +
"Layer 'Domain' does not depends on 'Presentation' layer.\n" +
"'Presentation' layer should not depend on anything but has dependencies in files:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project." +
"domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -358,16 +371,19 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result
.message
.shouldBeEqualTo(
"'fails when dependency is set that presentation layer not depends on domain (lambda scope)' " +
"test has failed. \n" +
"'Presentation' layer does not depends on 'Domain' layer failed. Files that depend on 'Domain' layer:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -385,16 +401,19 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result
.message
.shouldBeEqualTo(
"'fails when dependency is set that presentation layer not depends on domain (lambda files)' " +
"test has failed. \n" +
"'Presentation' layer does not depends on 'Domain' layer failed. Files that depend on 'Domain' layer:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -415,16 +434,19 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result
.message
.shouldBeEqualTo(
"'fails when dependency is set that presentation layer not depends on domain (parameter scope)' " +
"test has failed. \n" +
"'Presentation' layer does not depends on 'Domain' layer failed. Files that depend on 'Domain' layer:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -447,16 +469,19 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result
.message
.shouldBeEqualTo(
"'fails when dependency is set that presentation layer not depends on domain (parameter files)' " +
"test has failed. \n" +
"'Presentation' layer does not depends on 'Domain' layer failed. Files that depend on 'Domain' layer:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2." +
"project.domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand Down Expand Up @@ -521,13 +546,17 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result.message.shouldBeEqualTo(
"'fails when dependency is set that presentation layer depends on nothing and domain layer is included (lambda scope)' " +
"test has failed. \n" +
"'Presentation' layer should not depend on anything but has dependencies in files:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project." +
"domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -543,13 +572,17 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result.message.shouldBeEqualTo(
"'fails when dependency is set that presentation layer depends on nothing and domain layer is included (lambda files)' " +
"test has failed. \n" +
"'Presentation' layer should not depend on anything but has dependencies in files:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project." +
"domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -569,13 +602,17 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result.message.shouldBeEqualTo(
"'fails when dependency is set that presentation layer depends on nothing and domain layer is included (parameter scope)' " +
"test has failed. \n" +
"'Presentation' layer should not depend on anything but has dependencies in files:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project." +
"domain.DomainFirstClass ($filepath:3:1)",
)
}

Expand All @@ -595,13 +632,17 @@ class Architecture2Test {
}

// then
val filepath =
"file://$rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt"

result.message.shouldBeEqualTo(
"'fails when dependency is set that presentation layer depends on nothing and domain layer is included (parameter files)' " +
"test has failed. \n" +
"'Presentation' layer should not depend on anything but has dependencies in files:\n" +
"└── file $rootPath/lib/src/apiTest/kotlin/com/lemonappdev/konsist/architecture/" +
"assertarchitecture/architecture2/project/presentation/sample/PresentationThirdClass.kt\n" +
" └── import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project.domain.DomainFirstClass",
"└── File $filepath\n" +
" └── Import com.lemonappdev.konsist.architecture.assertarchitecture.architecture2.project." +
"domain.DomainFirstClass ($filepath:3:1)",
)
}
// endregion
Expand Down
Loading
Loading