Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KON-678 Add Layer Include #1506

Merged
merged 2 commits into from
Nov 4, 2024
Merged

KON-678 Add Layer Include #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7db038
Add Layer Include
igorwojda Nov 4, 2024
cfef151
Fix detekt
igorwojda Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions detekt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,27 +66,27 @@ comments:
endOfSentenceFormat: '([.?!][ \t\n\r\f<])|([.?!:]$)'
KDocReferencesNonPublicProperty:
active: false
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
OutdatedDocumentation:
active: false
matchTypeParameters: true
matchDeclarationsOrder: true
allowParamOnConstructorProperties: false
UndocumentedPublicClass:
active: false
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
searchInNestedClass: true
searchInInnerClass: true
searchInInnerObject: true
searchInInnerInterface: true
searchInProtectedClass: false
UndocumentedPublicFunction:
active: false
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
searchProtectedFunction: false
UndocumentedPublicProperty:
active: false
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
searchProtectedProperty: false

complexity:
Expand Down Expand Up @@ -155,14 +155,14 @@ complexity:
active: false
StringLiteralDuplication:
active: false
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
threshold: 3
ignoreAnnotation: true
excludeStringsWithLessThan5Characters: true
ignoreStringsRegex: '$^'
TooManyFunctions:
active: true
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**', '**/konsist/api/ext/sequence/**' ]
excludes: [ '**/test/**', '**/**Test/**', '**/konsist/api/ext/sequence/**' ]
thresholdInFiles: 25
thresholdInClasses: 25
thresholdInInterfaces: 25
Expand Down Expand Up @@ -238,7 +238,7 @@ exceptions:
- 'toString'
InstanceOfCheckForException:
active: true
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
NotImplementedDeclaration:
active: false
ObjectExtendsThrowable:
Expand All @@ -264,7 +264,7 @@ exceptions:
active: false
ThrowingExceptionsWithoutMessageOrCause:
active: true
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
exceptions:
- 'ArrayIndexOutOfBoundsException'
- 'Exception'
Expand All @@ -279,7 +279,7 @@ exceptions:
active: true
TooGenericExceptionCaught:
active: true
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
exceptionNames:
- 'ArrayIndexOutOfBoundsException'
- 'Error'
Expand Down Expand Up @@ -325,7 +325,7 @@ naming:
minimumFunctionNameLength: 3
FunctionNaming:
active: true
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**', '**/apiTest/**', '**/snippet/**', '**/jvmTest/**' ]
excludes: [ '**/test/**', '**/**Test/**', '**/apiTest/**', '**/snippet/**', '**/jvmTest/**' ]
functionPattern: '[a-z][a-zA-Z0-9]*'
excludeClassPattern: '$^'
ignoreAnnotated: [ 'Composable' ]
Expand Down Expand Up @@ -385,10 +385,10 @@ performance:
threshold: 3
ForEachOnRange:
active: true
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
SpreadOperator:
active: false
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
UnnecessaryPartOfBinaryExpression:
active: false
UnnecessaryTemporaryInstantiation:
Expand Down Expand Up @@ -455,7 +455,7 @@ potential-bugs:
active: true
LateinitUsage:
active: false
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
ignoreOnClassesPattern: ''
MapGetWithNotNullAssertionOperator:
active: true
Expand All @@ -478,7 +478,7 @@ potential-bugs:
active: true
UnsafeCallOnNullableType:
active: true
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**' ]
excludes: [ '**/test/**', '**/**Test/**' ]
UnsafeCast:
active: true
UnusedUnaryOperator:
Expand Down Expand Up @@ -551,7 +551,7 @@ style:
maxJumpCount: 1
MagicNumber:
active: true
excludes: [ '**/test/**', '**/integrationTest/**', '**/konsistTest/**', '**/*.kts' ]
excludes: [ '**/test/**', '**/**Test/**', '**/*.kts' ]
ignoreNumbers:
- '-1'
- '0'
Expand Down
21 changes: 10 additions & 11 deletions ...om/lemonappdev/konsist/architecture/assertarchitecture/architecture1/Architecture1Test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ class Architecture1Test {
"com.lemonappdev.konsist.architecture.assertarchitecture.architecture1.project.presentation..",
)

// region passes when dependency is set that layers are independent
// region passes when layers are independent
@Test
fun `passes when dependency is set that layers are independent (lambda scope)`() {
fun `passes when layers are independent (lambda scope)`() {
// then
scope
.assertArchitecture {
Expand All @@ -36,7 +36,7 @@ class Architecture1Test {
}

@Test
fun `passes when dependency is set that layers are independent (lambda files)`() {
fun `passes when layers are independent (lambda files)`() {
// then
scope
.files
Expand All @@ -47,7 +47,7 @@ class Architecture1Test {
}

@Test
fun `passes when dependency is set that layers are independent (parameter scope)`() {
fun `passes when layers are independent (parameter scope)`() {
// given
val layerDependencies =
architecture {
Expand All @@ -60,7 +60,7 @@ class Architecture1Test {
}

@Test
fun `passes when dependency is set that layers are independent (parameter files)`() {
fun `passes when layers are independent (parameter files)`() {
// given
val layerDependencies =
architecture {
Expand All @@ -76,10 +76,10 @@ class Architecture1Test {

// endregion

//region passes when dependency is set that Domain not depends on Presentation
//region passes when Domain not depends on Presentation

@Test
fun `passes when dependency is set that Domain not depends on Presentation (lambda scope)`() {
fun `passes when domain not depends on presentation (lambda scope)`() {
// then
scope
.assertArchitecture {
Expand All @@ -89,7 +89,7 @@ class Architecture1Test {
}

@Test
fun `passes when dependency is set that Domain not depends on Presentation (lambda files)`() {
fun `passes when Domain not depends on presentation (lambda files)`() {
// then
scope
.files
Expand All @@ -100,7 +100,7 @@ class Architecture1Test {
}

@Test
fun `passes when dependency is set that Domain not depends on Presentation (parameter scope)`() {
fun `passes when domain not depends on presentation (parameter scope)`() {
// given
val layerDependencies =
architecture {
Expand All @@ -113,7 +113,7 @@ class Architecture1Test {
}

@Test
fun `passes when dependency is set that Domain not depends on Presentation (parameter files)`() {
fun `passes when domain not depends on presentation (parameter files)`() {
// given
val layerDependencies =
architecture {
Expand All @@ -126,6 +126,5 @@ class Architecture1Test {
.files
.assertArchitecture(layerDependencies)
}

// endregion
}
Loading
Loading