KON-162 Figure out way to simplify tests in KoClassDeclaration #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorwojda
reviewed
May 16, 2023
| import org.amshove.kluent.shouldBeEqualTo | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| class KoClassDeclarationForNameTest { |
There was a problem hiding this comment.
It looks like we don't need this test, because KoClassDeclarationImpl does not define name property - this should be moved to KoNamedDeclarationImpl
|
We need to add tests to make sure every method/property and overridden method/property has a test class - this should be 1-1 eg.
|
|
Will be addressed in following PR |
nataliapeterwas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.