KON-673 Merge KoTypeDeclarationProvider and KoTypeProvider into one KoDeclarationCastProvider
#1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorwojda
approved these changes
Oct 25, 2024
igorwojda
deleted the
KON-673-merge-kotypeprovider-and-kotypedeclarationprovider-into-one-kodeclarationcastprovider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates
KoTypeDeclarationProviderandKoTypeProviderinto a single provider,KoDeclarationCastProvider. Both providers previously shared similar properties and responsibilities related to type casting. Merging them simplifies the codebase by centralizing these properties in one provider, improving maintainability.Now
isExternalTypeand everything connected with this property are deprecated and added new onesisExternalDeclaration. The change is due to the fact that this property does not only apply to types, but also to parents, for example.