Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KON-621 Wrong class is selected for nested classes #1254

Merged

Conversation

nataliapeterwas
Copy link
Collaborator

@nataliapeterwas nataliapeterwas commented Aug 12, 2024

Breaking API Changes:

  • fullyQualifiedName may have null value (eg. for nested functions and properties)
  • changed containingDeclaration property for parameters in class constructor - previously this property returned constructor declaration, now it returns class declaration

Copy link

@nataliapeterwas nataliapeterwas added bug-fix Malfunction or unexpected behavior breaking-api-change Breaks existing API labels Aug 12, 2024
@nataliapeterwas nataliapeterwas marked this pull request as ready for review August 30, 2024 12:26
@nataliapeterwas nataliapeterwas force-pushed the KON-621-issue-with-type-classes-with-the-same-names-new branch 2 times, most recently from f3ea5de to f4d88d7 Compare August 30, 2024 13:58
…same-names-new

# Conflicts:
#	lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoFunctionDeclarationCore.kt
#	lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoParameterDeclarationCore.kt
#	lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoPropertyDeclarationCore.kt
#	lib/src/main/kotlin/com/lemonappdev/konsist/core/util/TypeUtil.kt
@nataliapeterwas nataliapeterwas marked this pull request as draft September 6, 2024 13:02
@nataliapeterwas nataliapeterwas marked this pull request as ready for review September 6, 2024 14:39
@igorwojda igorwojda merged commit 057b30b into develop Sep 10, 2024
33 checks passed
@igorwojda igorwojda deleted the KON-621-issue-with-type-classes-with-the-same-names-new branch September 10, 2024 07:21
@igorwojda igorwojda changed the title KON-621 Issue with type classes with the same names KON-621 FullyQualifiedName may return null value Sep 10, 2024
@igorwojda igorwojda changed the title KON-621 FullyQualifiedName may return null value KON-621 Wrong class is selected for nested classes Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-api-change Breaks existing API bug-fix Malfunction or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants