KON-151 Add Suppress Annotation Support #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nataliapeterwas
commented
Apr 28, 2023
nataliapeterwas
commented
- Rename 'Check' to 'Assert'
- Upd annotations
- add suppress check in Assert.kt
- add complicated method to Assert and one test
- add KoBaseDeclaration.parentDeclaration property and test for it
- add KoBaseDeclaration.hasParentDeclaration function and tests for it
- add extensions for KoBaseDeclarationSequenceExt.kt
- upd assert suppress tests
- add first test (todo: upd it and add more)
- fix after merge
- add new tests
- Add correct tests
- fix spotless
…nnotation-support # Conflicts: # lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoBaseDeclaration.kt # lib/src/main/kotlin/com/lemonappdev/konsist/core/ext/KoBaseDeclarationSequenceExt.kt # lib/src/test/kotlin/com/lemonappdev/konsist/core/declaration/kobasedeclaration/KoBaseDeclarationTest.kt
…nnotation-support # Conflicts: # lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoBaseDeclaration.kt
igorwojda
reviewed
Apr 28, 2023
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoBaseDeclaration.kt
Outdated
Show resolved
Hide resolved
igorwojda
requested changes
Apr 28, 2023
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoAnnotationDeclaration.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoFileDeclaration.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/lemonappdev/konsist/core/ext/KoBaseDeclarationSequenceExt.kt
Outdated
Show resolved
Hide resolved
...pet/assert-not-check-declarations-in-file-with-suppress-annotation-with-konsist-prefix.kttxt
Outdated
Show resolved
Hide resolved
...sert/snippet/assert-not-check-declaration-with-suppress-annotation-with-konsist-prefix.kttxt
Outdated
Show resolved
Hide resolved
…nnotation-support # Conflicts: # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/declaration/kobasedeclaration/snippet/class-has-parent-declaration.kttxt # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/declaration/kobasedeclaration/snippet/class-with-parent-declaration.kttxt # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/declaration/kobasedeclaration/snippet/class-without-parent-declaration.kttxt # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/verify/assert/snippet/assert-not-check-declaration-with-suppress-annotation-with-konsist-prefix.kttxt # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/verify/assert/snippet/assert-not-check-declaration-with-suppress-annotation-without-konsist-prefix.kttxt # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/verify/assert/snippet/assert-not-check-declarations-in-file-with-suppress-annotation-with-konsist-prefix.kttxt # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/verify/assert/snippet/assert-not-check-declarations-in-file-with-suppress-annotation-without-konsist-prefix.kttxt # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/verify/assert/snippet/assert-not-check-nested-declarations-when-top-level-declaration-has-suppress-annotation-with-konsist-prefix.kttxt # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/verify/assert/snippet/assert-not-check-nested-declarations-when-top-level-declaration-has-suppress-annotation-without-konsist-prefix.kttxt # lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoAnnotationDeclarationImpl.kt # lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoBaseDeclaration.kt # lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoDeclarationImpl.kt # lib/src/test/kotlin/com/lemonappdev/konsist/api/ext/sequence/KoBaseDeclarationSequenceExtTest.kt
…nnotation-support # Conflicts: # lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/verify/assert/AssertTest.kt # lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoBaseDeclarationImpl.kt # lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoParametrizedDeclarationImpl.kt # lib/src/main/kotlin/com/lemonappdev/konsist/core/verify/Assert.kt
…nnotation-support # Conflicts: # lib/src/main/kotlin/com/lemonappdev/konsist/core/verify/Assert.kt
igorwojda
requested changes
May 7, 2023
lib/src/integrationTest/kotlin/com/lemonappdev/konsist/core/verify/assert/AssertTest.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoParametrizedDeclarationImpl.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoComplexDeclarationImpl.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoDeclarationImpl.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/lemonappdev/konsist/core/declaration/KoDeclarationImpl.kt
Show resolved
Hide resolved
nataliapeterwas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.