Parent not correctly identified as a class

[JordanLongstaff]

Tell us what version of Konsist you use.

0.17.3

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Describe the problem

Here's a class I have declared:

abstract class SimpleEventPacket(reader: PacketReader) : Packet.Server(reader)

The only parent that Konsist finds has its source declaration cast to KoExternalDeclarationCore instead of KoClassDeclarationCore, so its fully qualified name is Server instead of the full path ending in Packet.Server. I'm guessing it's because Packet.Server is an inner class.

There seems to be a bug in the sourceDeclaration implementation:

val innerName = if (name.contains(".")) name.substringBeforeLast(".") else name
val outerName = if (name.contains(".")) name.substringAfterLast(".") else name

Shouldn't it be the other way around?

Actual behaviour

The parent's sourceDeclaration property is cast to KoExternalDeclarationCore.

Expected behaviour

The sourceDeclaration should be a KoClassDeclarationCore.

[JordanLongstaff]

Tests are failing in this file in my repo. You can clone it if you want to debug.

[JordanLongstaff]

Except, now I've put in a workaround for the fix. My tests were failing because I was using classes.withParentOf(Packet.Server::class) and packetClass.hasParentOf<Packet.Server>().

[nataliapeterwas]

Thank you for reporting the problem. We will take a look! We especially appreciate you sharing the project; it will be incredibly helpful for us.

[nataliapeterwas]

Will be fixed in next release: PR