Adding distinguish comment. Fixes #2002 #2391
Conversation
crates/apub/src/objects/comment.rs
Outdated
| @@ -184,6 +184,7 @@ impl ApubObject for ApubComment { | |||
| updated: note.updated.map(|u| u.naive_local()), | |||
| deleted: None, | |||
| ap_id: Some(note.id.into()), | |||
| distinguished: None, // TODO how to do this? | |||
There was a problem hiding this comment.
@Nutomic Can you think of any field we could use for this? Or just ignore for now.
There was a problem hiding this comment.
I dont see any relevant field in activitystreams. You can just call it distinguished, and later we can migrate to a different name if needed. You will have to add the field in assets/lemmy/context.json, and to assets/lemmy/objects/note.json.
Keep in mind that we still dont federate admin status, so we cant verify that this was really sent by a mod/admin.
There was a problem hiding this comment.
Okay I think I got those now.
|
K got this working on lemmy-ui too, it was easier than expected. |
| local_user_view.person.id, | ||
| orig_comment.community.id, | ||
| ) | ||
| .await?; |
There was a problem hiding this comment.
So this means that admins/mods can distuingish any comment by another user? Then there should be some indication who did it.
But actually, i think that would make it less of a mod tool, and more like giving gold on reddit. Imo it would be better if admins/mods could only distinguish their own comments (when they are giving a warning or similar).
There was a problem hiding this comment.
No, there's a check right above this one that makes sure they can only do these actions on their own comments.
No description provided.