Add missing mod log entries for federated actions #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
commented
Apr 7, 2022
| blocking(context.pool(), move |conn| { | ||
| ModBanFromCommunity::create(conn, &form) | ||
| }) | ||
| .await??; |
There was a problem hiding this comment.
This was accidentally writing to the mod log for site bans, not community bans.
Nutomic
commented
Apr 7, 2022
| community_id: community.id, | ||
| removed: Some(false), | ||
| reason: None, | ||
| expires: None, |
There was a problem hiding this comment.
Why does this have an expires field? Doesnt seem to make any sense.
There was a problem hiding this comment.
I think the idea was similar to person, to allow for temp bans. Obvi we haven't implemented that yet tho. Pry fine to leave it for now, and then eventually add it if ppl ask for it. It'd be very similar to the commits for person, IE adding a ban_expires column.
|
@dessalines Could you also look through all the receive() methods in crates/apub/src/activities, to see if i missed something, or implemented something wrong? |
Nutomic
force-pushed
the
federated-mod-log
branch
from
27f8896
to
36d7c13
Compare
dessalines
reviewed
Apr 7, 2022
| @@ -161,6 +161,8 @@ impl ApubObject for ApubPost { | |||
| .await?; | |||
| let community = page.extract_community(context, request_counter).await?; | |||
|
|
|||
| // TODO: write mod log if stickied or locked changed | |||
dessalines
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.