Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create a post with a https://www.cbc.ca url #2089

Closed
smorks opened this issue Feb 6, 2022 · 4 comments
Closed

Can't create a post with a https://www.cbc.ca url #2089

smorks opened this issue Feb 6, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@smorks
Copy link
Contributor

smorks commented Feb 6, 2022

Issue Summary

Can't create posts with a https://www.cbc.ca/ url.

Steps to Reproduce

I've tested this on both lemmy.ca and lemmy.ml

  1. Click "Create a post" button in a community
  2. Enter any url to an article from https://www.cbc.ca/, for example: https://www.cbc.ca/sports/olympics/winter/hockey/beijing-olympic-womens-hockey-world-playing-catch-up-canada-us-1.6341266
  3. Click "Create". The button will just spin.

Technical details

I believe this is the relevant line from the logs. i don't see any other errors?

lemmy-lemmy-1  | 2022-02-06T03:33:24.347547Z  INFO Websocket Request{trace_id=00000000000000000000000000000000}:perform{self=CreatePost { name: "testing 1 2 3", community_id: CommunityId(3), url: Some(Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("www.cbc.ca")), port: None, path: "/sports/olympics/winter/hockey/beijing-olympic-womens-hockey-world-playing-catch-up-canada-us-1.6341266", query: None, fragment: None }), body: None, honeypot: None, nsfw: Some(false), auth: Sensitive }}:fetch_site_data:fetch_site_metadata: lemmy_utils::request: Fetching site metadata for url: https://www.cbc.ca/sports/olympics/winter/hockey/beijing-olympic-womens-hockey-world-playing-catch-up-canada-us-1.6341266
  • Please post your log: sudo docker-compose logs > lemmy_log.out.
  • What OS are you trying to install lemmy on? arch linux using docker
  • Any browser console errors? no

I'm a new lemmy admin, so let me know if you need any more info. Maybe this is something broken on the cbc website itself?

@smorks smorks added the bug Something isn't working label Feb 6, 2022
@dessalines
Copy link
Member

The HTML tokenizer that's required for fetching the site metadata is failing on that site, not sure why: https://enterprise.lemmy.ml/api/v3/post/site_metadata?url=https%3A%2F%2Fwww.cbc.ca%2Fsports%2Folympics%2Fwinter%2Fhockey%2Fbeijing-olympic-womens-hockey-world-playing-catch-up-canada-us-1.6341266

Looks like we're not the only one who has problems with that site: https://opengraphcheck.com/result.php?url=https%3A%2F%2Fwww.cbc.ca%2Fsports%2Folympics%2Fwinter%2Fhockey%2Fbeijing-olympic-womens-hockey-world-playing-catch-up-canada-us-1.6341266

Maybe they're blocking certain domains, checking browser agent, having circular references....no idea.

@Nutomic
Copy link
Member

Nutomic commented Feb 7, 2022

If it fails to fetch metadata, that should just be ignored and the link left with empty metadata. It shouldnt prevent the link from being posted.

@dessalines
Copy link
Member

I can try to figure out a way to add a timeout to that call.

@smorks
Copy link
Contributor Author

smorks commented Feb 7, 2022

thanks for looking into this, and thanks for all the work you've done on lemmy!

dessalines added a commit that referenced this issue Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants