Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerTube support (integration) #156

Closed
ghost opened this issue May 24, 2019 · 17 comments
Closed

PeerTube support (integration) #156

ghost opened this issue May 24, 2019 · 17 comments
Labels
enhancement New feature or request type: duplicate This issue or pull request already exists

Comments

@ghost
Copy link

ghost commented May 24, 2019

No description provided.

@dessalines
Copy link
Member

Im not sure what the integration would be, this would mainly be just linking to peertube instances right?

Since the federation in lemmy is following communities, and not people, that part of it might not apply.

@anewton1998
Copy link

Perhaps pulling the preview image from a peertube video for display? That's what I would imagine, I guess.

@ghost
Copy link
Author

ghost commented May 29, 2019

Perhaps pulling the preview image from a peertube video for display? That's what I would imagine, I guess.

Yes and then one click and you're watching the video, whithout being redirected anywhere. Just like reddit with youtube videos.
Maybe there are other 'clever' ways of integrating peertube into lemmy but for now that's all I can think of.

@dessalines
Copy link
Member

If anyone knows of a good library to get html previews from a link (like imgur link to <img, youtube to <video, let me know cause I haven't been able to find one. And it'd be super useful for ppl who just want to paste in links to wherever as opposed to providing an image URL for the post URL.

RES has some code for this, but its a monster, and they have to keep updating it every time these services change their schemes.

@anewton1998
Copy link

Would this opengraph library work?
https://github.com/kumabook/opengraph

@dessalines
Copy link
Member

It would only work for image previews / thumbnails, not for videos, audio previews, etc. I want a library that takes in everything from a soundcloud url, to a youtube link, to imgur, giphy, peertube, and builds html previews, or links to the source urls and says their type.

The other thing is I'd really like to keep url processing and transforms on the front end.

@filippodb
Copy link

It would only work for image previews / thumbnails, not for videos, audio previews, etc. I want a library that takes in everything from a soundcloud url, to a youtube link, to imgur, giphy, peertube, and builds html previews, or links to the source urls and says their type.

The other thing is I'd really like to keep url processing and transforms on the front end.

a possible solution that support 600 media providers is here: https://embed.ly/providers

an open alternative is: https://noembed.com

or: https://oembed.com

none of them support peer tube yet.

@ghost
Copy link
Author

ghost commented Jun 9, 2019

an open alternative is: https://noembed.com

or: https://oembed.com

I could open a new issues in those repos (https://github.com/leedo/noembed and https://github.com/iamcal/oembed) and ask to support peertube links.

@dessalines
Copy link
Member

Would be a good idea.

@ghost
Copy link
Author

ghost commented Jan 4, 2020

Since this issue has been closed, does this mean that no PeerTube support is planned?

@dessalines
Copy link
Member

Its a link aggregator, peertube links are accepted. If its about embedding videos into lemmy the same way there are image previews, then that's a different issue that needs an embed provider for all kinds of content, not just peertube.

@filippodb
Copy link

peertube is on activitypub, it's part of the fediverse like lemmy, so it it's strange to see it's not fully supported.
I mean, fediverse projects should help each other and peertube support should come before supporting youtube, vimeo, etc.

@filippodb
Copy link

maybe you can see how mastodon works integrating peertube video.

@dessalines
Copy link
Member

What does fully supported mean?

@filippodb
Copy link

fully supported like on mastodon, so the comments made on lemmy to be published on peertube and replies on peertube to show on lemmy too, see the video:

https://peertube.cpy.re/videos/watch/da2b08d4-a242-4170-b32a-4ec8cbdca701?autoplay=1&auto_play=1

I believe this integration will help both platform.

@dessalines
Copy link
Member

Ah. Okay so that is a federated user follow. Eventually these will be supported in lemmy, but after the federated community follow.

@dessalines dessalines reopened this Jan 5, 2020
@Nutomic Nutomic added Component: Frontend enhancement New feature or request labels Jan 11, 2020
@dessalines
Copy link
Member

Dupe of #752

@dessalines dessalines added the type: duplicate This issue or pull request already exists label Jul 22, 2020
dessalines pushed a commit that referenced this issue Jan 15, 2021
…#1325) (#156)

Don't send activities to ourselves

Ensure that comments are always delivered to the parent creator (fixes #1325)

Co-authored-by: Felix Ableitner <me@nutomic.com>
Reviewed-on: https://yerbamate.ml/LemmyNet/lemmy/pulls/156
Co-Authored-By: dessalines <dessalines@noreply.yerbamate.ml>
Co-Committed-By: dessalines <dessalines@noreply.yerbamate.ml>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request type: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants