Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off html in markdown. Fixes #650 #657

Merged
merged 1 commit into from
May 24, 2022
Merged

Turn off html in markdown. Fixes #650 #657

merged 1 commit into from
May 24, 2022

Conversation

dessalines
Copy link
Member

No description provided.

@dessalines dessalines requested a review from Nutomic May 22, 2022 22:04
Nutomic
Nutomic approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@Nutomic Nutomic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be considered a breaking change, but also fixes potential security issues. Do you plan to release it in 0.16.4 or 0.17.0?

@dessalines
Copy link
Member Author

There are no API changes or anything like that, its only a change in how markdown is rendered. I'm up for either, but IMO sooner than later, because some people are injecting a lot of weird things into lemmy like tooltips that block other buttons and such.

@Nutomic Nutomic enabled auto-merge (squash) May 24, 2022 12:18
@Nutomic
Copy link
Member

Nutomic commented May 24, 2022 •
edited
Loading

Okay sounds fine. Btw lint is failing.

@Nutomic Nutomic merged commit 0fc7808 into main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nutomic Nutomic Nutomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dessalines @Nutomic