Fix language names #580
Fix language names #580
Conversation
| return allowedLangs[0]; | ||
| } | ||
|
|
||
| export function getMomentLanguage(): string { |
There was a problem hiding this comment.
This function is not necessary at all, as momentjs does it much smarter on its own.
| { resource: vi, code: "vi", name: "Tiếng Việt" }, | ||
| { resource: zh, code: "zh", name: "中文" }, | ||
| { resource: zh_Hant, code: "zh_Hant", name: "文言" }, | ||
| ]; |
There was a problem hiding this comment.
Merge the different language lists in a single place for simplicity, also sort alphabetically.
| } else { | ||
| return lang; | ||
| return [lang]; | ||
| } | ||
| } |
There was a problem hiding this comment.
Makes more sense to return a list of preferred languages here, momentjs uses this. Unfortunately i18next doesnt, it can only set a single language. So if a word isnt translated into the browser language, it will always fallback to English, even if the browser specifies another fallback language.
| { resource: vi, code: "vi", name: "Tiếng Việt" }, | ||
| { resource: zh, code: "zh", name: "中文" }, | ||
| { resource: zh_Hant, code: "zh_Hant", name: "文言" }, | ||
| ]; |
| @@ -527,7 +525,7 @@ export class Settings extends Component<any, SettingsState> { | |||
| .sort((a, b) => a.code.localeCompare(b.code)) | |||
| .map(lang => ( | |||
| <option value={lang.code}> | |||
| {getNativeLanguageName(lang.code)} | |||
| {getLanguages(lang.code)[0]} | |||
There was a problem hiding this comment.
Use the language name here, and I'm not sure why this needed to call getLanguages again.
There was a problem hiding this comment.
True, i changed this before merging the language lists.
As described in LemmyNet/joinlemmy-site#76 (comment)
There is still a problem in that all language names are rendered left to right, even those which should be rtl (like Arabic).